You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/18 02:11:52 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39628: [SPARK-40264][ML] followup pydoc edits

HyukjinKwon commented on code in PR #39628:
URL: https://github.com/apache/spark/pull/39628#discussion_r1073022795


##########
python/pyspark/ml/functions.py:
##########
@@ -486,6 +486,7 @@ def predict(inputs: np.ndarray) -> np.ndarray:
     data = np.arange(0, 1000, dtype=np.float64).reshape(-1, 4)

Review Comment:
   Can we follow https://numpydoc.readthedocs.io/en/latest/format.html and add the examples as a proper doctest?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org