[GitHub] mcvsubbu commented on a change in pull request #3604: Add ControllerLeadershipManager as single place to check controller leadership changes

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #3604: Add ControllerLeadershipManager as single place to check controller leadership changes
URL: https://github.com/apache/incubator-pinot/pull/3604#discussion_r240461328
 
 

 ##########
 File path: pinot-controller/src/main/java/com/linkedin/pinot/controller/ControllerLeadershipManager.java
 ##########
 @@ -0,0 +1,116 @@
+/**
+ * Copyright (C) 2014-2018 LinkedIn Corp. (pinot-core@linkedin.com)
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *         http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.linkedin.pinot.controller;
+
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import org.apache.helix.HelixManager;
+import org.apache.helix.api.listeners.ControllerChangeListener;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+/**
+ * Single place for listening on controller changes
+ * This should be created at controller startup and everyone who wants to listen to controller changes should subscribe
+ */
+public class ControllerLeadershipManager {
 
 Review comment:
   Should there be a stop method here that calls onBecomingNonLeader() once and shuts this service down?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org