You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Pranay Pandey (JIRA)" <ji...@apache.org> on 2009/03/02 09:50:13 UTC
[jira] Created: (OFBIZ-2220) Add new field for "Cancel Back Orders
Date", like others for OrderItem. Show these on Purchase order PDF.
Add new field for "Cancel Back Orders Date", like others for OrderItem. Show these on Purchase order PDF.
---------------------------------------------------------------------------------------------------------
Key: OFBIZ-2220
URL: https://issues.apache.org/jira/browse/OFBIZ-2220
Project: OFBiz
Issue Type: Sub-task
Components: order
Affects Versions: SVN trunk
Reporter: Pranay Pandey
Priority: Minor
Fix For: SVN trunk
There should be one field "cancelBackOrdersDate" associated with order items which will help to cancel those orders which have crossed this date.
*Implementation Notes:*
Add new field for cancelBackOrdersDate", like others for OrderItem. Show on Purchase Order PDF.
Add a service to look at all purchase orders with the field set and if the date is in the past then it should cancel those orders; the service should run on a schedule, once per day.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2220) Add new field for "Cancel Back Orders
Date", like others for OrderItem. Show these on Purchase order PDF.
Posted by "Deepesh Kapoor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Deepesh Kapoor updated OFBIZ-2220:
----------------------------------
Attachment: ofbiz-2220.patch
> Add new field for "Cancel Back Orders Date", like others for OrderItem. Show these on Purchase order PDF.
> ---------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2220
> URL: https://issues.apache.org/jira/browse/OFBIZ-2220
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2220.patch, ofbiz-2220.patch
>
>
> There should be one field "cancelBackOrdersDate" associated with order items which will help to cancel those orders which have crossed this date.
> *Implementation Notes:*
> Add new field for cancelBackOrdersDate", like others for OrderItem. Show on Purchase Order PDF.
> Add a service to look at all purchase orders with the field set and if the date is in the past then it should cancel those orders; the service should run on a schedule, once per day.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2220) Add new field for "Cancel Back
Orders Date", like others for OrderItem. Show these on Purchase order PDF.
Posted by "Pranay Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682300#action_12682300 ]
Pranay Pandey commented on OFBIZ-2220:
--------------------------------------
I tested this patch for following and found no problems:
# I am Able to provide "cancelBackOrderDate" while creating purchase order.
# After creation on of PO if "cancelBackOrderDate" exists then its being shown in order detail page and on order pdf.
# Checked for OrderItems in webtools entries found.
# Ran service "cancelAllBackOrders" from webtools and saw the result that POs are cancelled if the "cancelBackOrderDate" is in past.
# Tested service for 3 cases for POs
## PO with "cancelBackOrderDate" is in past -- This order got cancelled.
## PO without "cancelBackOrderDate" -- Not affected.
## PO with "cancelBackOrderDate" is in future -- Not affected. (Will be cancelled by the scheduled service when the date is passed)
Now I think one of the committer can have a look at this patch :)
> Add new field for "Cancel Back Orders Date", like others for OrderItem. Show these on Purchase order PDF.
> ---------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2220
> URL: https://issues.apache.org/jira/browse/OFBIZ-2220
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch
>
>
> There should be one field "cancelBackOrdersDate" associated with order items which will help to cancel those orders which have crossed this date.
> *Implementation Notes:*
> Add new field for cancelBackOrdersDate", like others for OrderItem. Show on Purchase Order PDF.
> Add a service to look at all purchase orders with the field set and if the date is in the past then it should cancel those orders; the service should run on a schedule, once per day.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2220) Add new field for "Cancel Back Orders
Date", like others for OrderItem. Show these on Purchase order PDF.
Posted by "Pranay Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pranay Pandey updated OFBIZ-2220:
---------------------------------
Attachment: ofbiz-2220.patch
Here is the updated patch for this issue.
I just resolved all the conflicts because of recent commits in same files.
> Add new field for "Cancel Back Orders Date", like others for OrderItem. Show these on Purchase order PDF.
> ---------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2220
> URL: https://issues.apache.org/jira/browse/OFBIZ-2220
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch
>
>
> There should be one field "cancelBackOrdersDate" associated with order items which will help to cancel those orders which have crossed this date.
> *Implementation Notes:*
> Add new field for cancelBackOrdersDate", like others for OrderItem. Show on Purchase Order PDF.
> Add a service to look at all purchase orders with the field set and if the date is in the past then it should cancel those orders; the service should run on a schedule, once per day.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2220) Add new field for "Cancel Back Orders
Date", like others for OrderItem. Show these on Purchase order PDF.
Posted by "Deepesh Kapoor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Deepesh Kapoor updated OFBIZ-2220:
----------------------------------
Attachment: (was: order.patch)
> Add new field for "Cancel Back Orders Date", like others for OrderItem. Show these on Purchase order PDF.
> ---------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2220
> URL: https://issues.apache.org/jira/browse/OFBIZ-2220
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Priority: Minor
> Fix For: SVN trunk
>
>
> There should be one field "cancelBackOrdersDate" associated with order items which will help to cancel those orders which have crossed this date.
> *Implementation Notes:*
> Add new field for cancelBackOrdersDate", like others for OrderItem. Show on Purchase Order PDF.
> Add a service to look at all purchase orders with the field set and if the date is in the past then it should cancel those orders; the service should run on a schedule, once per day.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2220) Add new field for "Cancel Back
Orders Date", like others for OrderItem. Show these on Purchase order PDF.
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679987#action_12679987 ]
David E. Jones commented on OFBIZ-2220:
---------------------------------------
Why do you say it is misleading? This is literally referring to "back order" on purpose. Keep in mind it is not back orders from the internal Company, but back orders from the supplier (ie when the supplier doesn't have something in stock and so it is on back order with the supplier).
> Add new field for "Cancel Back Orders Date", like others for OrderItem. Show these on Purchase order PDF.
> ---------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2220
> URL: https://issues.apache.org/jira/browse/OFBIZ-2220
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2220.patch
>
>
> There should be one field "cancelBackOrdersDate" associated with order items which will help to cancel those orders which have crossed this date.
> *Implementation Notes:*
> Add new field for cancelBackOrdersDate", like others for OrderItem. Show on Purchase Order PDF.
> Add a service to look at all purchase orders with the field set and if the date is in the past then it should cancel those orders; the service should run on a schedule, once per day.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (OFBIZ-2220) Add new field for "Cancel
Back Orders Date", like others for OrderItem. Show these on Purchase order
PDF.
Posted by "Pranay Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682300#action_12682300 ]
Pranay Pandey edited comment on OFBIZ-2220 at 3/16/09 5:21 AM:
---------------------------------------------------------------
I tested this patch for following and found no problems:
# I am Able to provide "cancelBackOrderDate" while creating purchase order.
# After creation on of PO if "cancelBackOrderDate" exists then its being shown in order detail page and on order pdf.
# Checked for OrderItems in webtools entries found.
# Ran service "cancelAllBackOrders" from webtools and saw the result that POs are cancelled if the "cancelBackOrderDate" is in past.
# Tested service for 3 cases for POs
#* PO with "cancelBackOrderDate" is in past -- This order got cancelled.
#* PO without "cancelBackOrderDate" -- Not affected.
#* PO with "cancelBackOrderDate" is in future -- Not affected. (Will be cancelled by the scheduled service when the date is passed)
Now I think one of the committer can have a look at this patch :)
was (Author: pandeypranay):
I tested this patch for following and found no problems:
# I am Able to provide "cancelBackOrderDate" while creating purchase order.
# After creation on of PO if "cancelBackOrderDate" exists then its being shown in order detail page and on order pdf.
# Checked for OrderItems in webtools entries found.
# Ran service "cancelAllBackOrders" from webtools and saw the result that POs are cancelled if the "cancelBackOrderDate" is in past.
# Tested service for 3 cases for POs
## PO with "cancelBackOrderDate" is in past -- This order got cancelled.
## PO without "cancelBackOrderDate" -- Not affected.
## PO with "cancelBackOrderDate" is in future -- Not affected. (Will be cancelled by the scheduled service when the date is passed)
Now I think one of the committer can have a look at this patch :)
> Add new field for "Cancel Back Orders Date", like others for OrderItem. Show these on Purchase order PDF.
> ---------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2220
> URL: https://issues.apache.org/jira/browse/OFBIZ-2220
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch
>
>
> There should be one field "cancelBackOrdersDate" associated with order items which will help to cancel those orders which have crossed this date.
> *Implementation Notes:*
> Add new field for cancelBackOrdersDate", like others for OrderItem. Show on Purchase Order PDF.
> Add a service to look at all purchase orders with the field set and if the date is in the past then it should cancel those orders; the service should run on a schedule, once per day.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2220) Add new field for "Cancel Back
Orders Date", like others for OrderItem. Show these on Purchase order PDF.
Posted by "Pranay Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682258#action_12682258 ]
Pranay Pandey commented on OFBIZ-2220:
--------------------------------------
Thanks Deepesh for updated patch. But when I tried to apply the patch found conflicts :).
> Add new field for "Cancel Back Orders Date", like others for OrderItem. Show these on Purchase order PDF.
> ---------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2220
> URL: https://issues.apache.org/jira/browse/OFBIZ-2220
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch
>
>
> There should be one field "cancelBackOrdersDate" associated with order items which will help to cancel those orders which have crossed this date.
> *Implementation Notes:*
> Add new field for cancelBackOrdersDate", like others for OrderItem. Show on Purchase Order PDF.
> Add a service to look at all purchase orders with the field set and if the date is in the past then it should cancel those orders; the service should run on a schedule, once per day.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2220) Add new field for "Cancel Back
Orders Date", like others for OrderItem. Show these on Purchase order PDF.
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679985#action_12679985 ]
Vikas Mayur commented on OFBIZ-2220:
------------------------------------
Looking at the description, isn't cancelBackOrdersDate field is misleading to Back Orders?
What about something like cancelOrdersBackDate or cancelBackDateOrders?
> Add new field for "Cancel Back Orders Date", like others for OrderItem. Show these on Purchase order PDF.
> ---------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2220
> URL: https://issues.apache.org/jira/browse/OFBIZ-2220
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2220.patch
>
>
> There should be one field "cancelBackOrdersDate" associated with order items which will help to cancel those orders which have crossed this date.
> *Implementation Notes:*
> Add new field for cancelBackOrdersDate", like others for OrderItem. Show on Purchase Order PDF.
> Add a service to look at all purchase orders with the field set and if the date is in the past then it should cancel those orders; the service should run on a schedule, once per day.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2220) Add new field for "Cancel Back Orders
Date", like others for OrderItem. Show these on Purchase order PDF.
Posted by "Deepesh Kapoor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Deepesh Kapoor updated OFBIZ-2220:
----------------------------------
Attachment: ofbiz-2220.patch
Thanks Pranay for reviewing my patch.
I have made the required changes now according to your suggestions.
> Add new field for "Cancel Back Orders Date", like others for OrderItem. Show these on Purchase order PDF.
> ---------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2220
> URL: https://issues.apache.org/jira/browse/OFBIZ-2220
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch
>
>
> There should be one field "cancelBackOrdersDate" associated with order items which will help to cancel those orders which have crossed this date.
> *Implementation Notes:*
> Add new field for cancelBackOrdersDate", like others for OrderItem. Show on Purchase Order PDF.
> Add a service to look at all purchase orders with the field set and if the date is in the past then it should cancel those orders; the service should run on a schedule, once per day.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2220) Add new field for "Cancel Back Orders
Date", like others for OrderItem. Show these on Purchase order PDF.
Posted by "Deepesh Kapoor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Deepesh Kapoor updated OFBIZ-2220:
----------------------------------
Attachment: order.patch
Here is the patch for adding new field for "Cancel Back Orders Date", like others for OrderItem and showing it on Purchase Order PDF.
To test this patch follow these steps:
1. Start creating a new purchase order, the field for providing "cancel back order date" is provided right below the existing fields ship before & ship after date.
2. The order view page will reflect the added "cancel back order date".
3. If the assigned cancel back order date is passed for any order, than the scheduled service (midnight daily) makes sure that it gets canceled.
To test this we can :
a. Create a new PO.
b. Assign it a cancel back order date which is already passed.
c. Check the behavior of the service by explicitly running it through webtools.
4. The PO PDF reflects the cancel back order date for all those orders which are assigned this date. This can be tested by generating PDF from order view page.
> Add new field for "Cancel Back Orders Date", like others for OrderItem. Show these on Purchase order PDF.
> ---------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2220
> URL: https://issues.apache.org/jira/browse/OFBIZ-2220
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Priority: Minor
> Fix For: SVN trunk
>
>
> There should be one field "cancelBackOrdersDate" associated with order items which will help to cancel those orders which have crossed this date.
> *Implementation Notes:*
> Add new field for cancelBackOrdersDate", like others for OrderItem. Show on Purchase Order PDF.
> Add a service to look at all purchase orders with the field set and if the date is in the past then it should cancel those orders; the service should run on a schedule, once per day.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2220) Add new field for "Cancel Back
Orders Date", like others for OrderItem. Show these on Purchase order PDF.
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683026#action_12683026 ]
Vikas Mayur commented on OFBIZ-2220:
------------------------------------
Thanks Deepesh and Pranay!
Patch is in trunk rev. 755596.
The service cancelAllBackOrders, If you want to change its name to some closer/appropriate name (that clearly state the purpose) then please feel free to re-open this issue.
> Add new field for "Cancel Back Orders Date", like others for OrderItem. Show these on Purchase order PDF.
> ---------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2220
> URL: https://issues.apache.org/jira/browse/OFBIZ-2220
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch
>
>
> There should be one field "cancelBackOrdersDate" associated with order items which will help to cancel those orders which have crossed this date.
> *Implementation Notes:*
> Add new field for cancelBackOrdersDate", like others for OrderItem. Show on Purchase Order PDF.
> Add a service to look at all purchase orders with the field set and if the date is in the past then it should cancel those orders; the service should run on a schedule, once per day.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2220) Add new field for "Cancel Back
Orders Date", like others for OrderItem. Show these on Purchase order PDF.
Posted by "Pranay Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681350#action_12681350 ]
Pranay Pandey commented on OFBIZ-2220:
--------------------------------------
Hello Deepesh,
I reviewed your patch. Here are my comments for improvements:
# Update the patch to OFBiz head.
# UiLabel cancelBackOrderDate should be FormFieldTitle_ cancelBackOrderDate
# In OrderView.groovy, first find list of orderItems then do getfirst on the list instead giving a hardcoded value for orderItemSeqId.
# In ShoppingCartServices.java we don't need to do cart.setCancelBackOrderDate(cartShipGroupIndex, sg.getTimestamp("cancelBackOrderDate")); as this is not related to shipgroup.
# <field name="cancelBackOrderDate" type="date-time"></field> doesn't need to be there in "OrderItemShipGroup" entity.
# Improve the short-description in the service implementation for cancelAllBackOrders, it should be "Cancels all back orders from supplier"
# Check in CheckOutHelper.java do we really need to have this field in methods setCheckOutShippingOptions and setCheckOutShippingOptionsInternal(No need to set this field for shipping options)
# Also Check setter and getter methods for cancelBackOrderDate.
Also check for the unused code thats not needed and upload the updated patch.
> Add new field for "Cancel Back Orders Date", like others for OrderItem. Show these on Purchase order PDF.
> ---------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2220
> URL: https://issues.apache.org/jira/browse/OFBIZ-2220
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2220.patch, ofbiz-2220.patch
>
>
> There should be one field "cancelBackOrdersDate" associated with order items which will help to cancel those orders which have crossed this date.
> *Implementation Notes:*
> Add new field for cancelBackOrdersDate", like others for OrderItem. Show on Purchase Order PDF.
> Add a service to look at all purchase orders with the field set and if the date is in the past then it should cancel those orders; the service should run on a schedule, once per day.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2220) Add new field for "Cancel Back Orders
Date", like others for OrderItem. Show these on Purchase order PDF.
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vikas Mayur closed OFBIZ-2220.
------------------------------
Resolution: Fixed
> Add new field for "Cancel Back Orders Date", like others for OrderItem. Show these on Purchase order PDF.
> ---------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2220
> URL: https://issues.apache.org/jira/browse/OFBIZ-2220
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch
>
>
> There should be one field "cancelBackOrdersDate" associated with order items which will help to cancel those orders which have crossed this date.
> *Implementation Notes:*
> Add new field for cancelBackOrdersDate", like others for OrderItem. Show on Purchase Order PDF.
> Add a service to look at all purchase orders with the field set and if the date is in the past then it should cancel those orders; the service should run on a schedule, once per day.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (OFBIZ-2220) Add new field for "Cancel
Back Orders Date", like others for OrderItem. Show these on Purchase order
PDF.
Posted by "Pranay Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681350#action_12681350 ]
Pranay Pandey edited comment on OFBIZ-2220 at 3/12/09 8:15 AM:
---------------------------------------------------------------
Hello Deepesh,
I reviewed your patch. Here are my comments for improvements:
# Update the patch to OFBiz head.
# UiLabel cancelBackOrderDate should be FormFieldTitle_ cancelBackOrderDate
# In OrderView.groovy, first find list of orderItems then do getfirst on the list instead giving a hardcoded value for orderItemSeqId.
# In ShoppingCartServices.java we don't need to do cart.setCancelBackOrderDate(cartShipGroupIndex, sg.getTimestamp("cancelBackOrderDate")); as this is not related to shipgroup.
# <field name="cancelBackOrderDate" type="date-time"></field> doesn't need to be there in "OrderItemShipGroup" entity.
# Improve the short-description in the service implementation for cancelAllBackOrders, it should be "Cancels all back orders from supplier"
# Check in CheckOutHelper.java do we really need to have this field in methods setCheckOutShippingOptions and setCheckOutShippingOptionsInternal(No need to set this field for shipping options)
# Also Check setter and getter methods for cancelBackOrderDate.
Also check for the unused code thats not needed and upload the updated patch.
was (Author: pandeypranay):
Hello Deepesh,
I reviewed your patch. Here are my comments for improvements:
# Update the patch to OFBiz head.
# UiLabel cancelBackOrderDate should be FormFieldTitle_ cancelBackOrderDate
# In OrderView.groovy, first find list of orderItems then do getfirst on the list instead giving a hardcoded value for orderItemSeqId.
# In ShoppingCartServices.java we don't need to do cart.setCancelBackOrderDate(cartShipGroupIndex, sg.getTimestamp("cancelBackOrderDate")); as this is not related to shipgroup.
# <field name="cancelBackOrderDate" type="date-time"></field> doesn't need to be there in "OrderItemShipGroup" entity.
# Improve the short-description in the service implementation for cancelAllBackOrders, it should be "Cancels all back orders from supplier"
# Check in CheckOutHelper.java do we really need to have this field in methods setCheckOutShippingOptions and setCheckOutShippingOptionsInternal(No need to set this field for shipping options)
# Also Check setter and getter methods for cancelBackOrderDate.
Also check for the unused code thats not needed and upload the updated patch.
> Add new field for "Cancel Back Orders Date", like others for OrderItem. Show these on Purchase order PDF.
> ---------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2220
> URL: https://issues.apache.org/jira/browse/OFBIZ-2220
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2220.patch, ofbiz-2220.patch
>
>
> There should be one field "cancelBackOrdersDate" associated with order items which will help to cancel those orders which have crossed this date.
> *Implementation Notes:*
> Add new field for cancelBackOrdersDate", like others for OrderItem. Show on Purchase Order PDF.
> Add a service to look at all purchase orders with the field set and if the date is in the past then it should cancel those orders; the service should run on a schedule, once per day.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2220) Add new field for "Cancel Back Orders
Date", like others for OrderItem. Show these on Purchase order PDF.
Posted by "Deepesh Kapoor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Deepesh Kapoor updated OFBIZ-2220:
----------------------------------
Attachment: ofbiz-2220.patch
> Add new field for "Cancel Back Orders Date", like others for OrderItem. Show these on Purchase order PDF.
> ---------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2220
> URL: https://issues.apache.org/jira/browse/OFBIZ-2220
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2220.patch
>
>
> There should be one field "cancelBackOrdersDate" associated with order items which will help to cancel those orders which have crossed this date.
> *Implementation Notes:*
> Add new field for cancelBackOrdersDate", like others for OrderItem. Show on Purchase Order PDF.
> Add a service to look at all purchase orders with the field set and if the date is in the past then it should cancel those orders; the service should run on a schedule, once per day.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2220) Add new field for "Cancel Back
Orders Date", like others for OrderItem. Show these on Purchase order PDF.
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680419#action_12680419 ]
Vikas Mayur commented on OFBIZ-2220:
------------------------------------
Thanks David for clarification. I raised my question by reading the small description (Which I could not understand). Now it make sense.
> Add new field for "Cancel Back Orders Date", like others for OrderItem. Show these on Purchase order PDF.
> ---------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2220
> URL: https://issues.apache.org/jira/browse/OFBIZ-2220
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2220.patch
>
>
> There should be one field "cancelBackOrdersDate" associated with order items which will help to cancel those orders which have crossed this date.
> *Implementation Notes:*
> Add new field for cancelBackOrdersDate", like others for OrderItem. Show on Purchase Order PDF.
> Add a service to look at all purchase orders with the field set and if the date is in the past then it should cancel those orders; the service should run on a schedule, once per day.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2220) Add new field for "Cancel Back Orders
Date", like others for OrderItem. Show these on Purchase order PDF.
Posted by "Deepesh Kapoor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Deepesh Kapoor updated OFBIZ-2220:
----------------------------------
Attachment: ofbiz-2220.patch
> Add new field for "Cancel Back Orders Date", like others for OrderItem. Show these on Purchase order PDF.
> ---------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2220
> URL: https://issues.apache.org/jira/browse/OFBIZ-2220
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch
>
>
> There should be one field "cancelBackOrdersDate" associated with order items which will help to cancel those orders which have crossed this date.
> *Implementation Notes:*
> Add new field for cancelBackOrdersDate", like others for OrderItem. Show on Purchase Order PDF.
> Add a service to look at all purchase orders with the field set and if the date is in the past then it should cancel those orders; the service should run on a schedule, once per day.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2220) Add new field for "Cancel Back Orders
Date", like others for OrderItem. Show these on Purchase order PDF.
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vikas Mayur reassigned OFBIZ-2220:
----------------------------------
Assignee: Vikas Mayur
> Add new field for "Cancel Back Orders Date", like others for OrderItem. Show these on Purchase order PDF.
> ---------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2220
> URL: https://issues.apache.org/jira/browse/OFBIZ-2220
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch
>
>
> There should be one field "cancelBackOrdersDate" associated with order items which will help to cancel those orders which have crossed this date.
> *Implementation Notes:*
> Add new field for cancelBackOrdersDate", like others for OrderItem. Show on Purchase Order PDF.
> Add a service to look at all purchase orders with the field set and if the date is in the past then it should cancel those orders; the service should run on a schedule, once per day.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2220) Add new field for "Cancel Back Orders
Date", like others for OrderItem. Show these on Purchase order PDF.
Posted by "Pranay Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pranay Pandey updated OFBIZ-2220:
---------------------------------
Attachment: ofbiz-2220.patch
Here is the updated patch for this issue.
I resolved the conflicts and removed unused code.
> Add new field for "Cancel Back Orders Date", like others for OrderItem. Show these on Purchase order PDF.
> ---------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2220
> URL: https://issues.apache.org/jira/browse/OFBIZ-2220
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch, ofbiz-2220.patch
>
>
> There should be one field "cancelBackOrdersDate" associated with order items which will help to cancel those orders which have crossed this date.
> *Implementation Notes:*
> Add new field for cancelBackOrdersDate", like others for OrderItem. Show on Purchase Order PDF.
> Add a service to look at all purchase orders with the field set and if the date is in the past then it should cancel those orders; the service should run on a schedule, once per day.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.