[jira] [Commented] (HADOOP-11876) Refactor code to make it more readable, minor maybePrintStats bug

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-11876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511608#comment-14511608 ] 

Hadoop QA commented on HADOOP-11876:
------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 35s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace. |
| {color:green}+1{color} | javac |   7m 30s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 25s | There were no new javadoc warning messages. |
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   7m 51s | There were no new checkstyle issues. |
| {color:green}+1{color} | install |   1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   0m 38s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | tools/hadoop tests |   6m 16s | Tests passed in hadoop-distcp. |
| | |  48m 48s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12727961/HADOOP-11876.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / cf6c8a1 |
| hadoop-distcp test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/6174/artifact/patchprocess/testrun_hadoop-distcp.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/6174/testReport/ |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6174/console |


This message was automatically generated.

> Refactor code to make it more readable, minor maybePrintStats bug
> -----------------------------------------------------------------
>
>                 Key: HADOOP-11876
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11876
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: tools/distcp
>    Affects Versions: 3.0.0
>            Reporter: Zoran Dimitrijevic
>            Assignee: Zoran Dimitrijevic
>            Priority: Trivial
>         Attachments: HADOOP-11876.patch
>
>
> This is related to HADOOP-11827 patch from few days ago. I've noticed a minor bug in maybePrintStats logic which is called only when new directory is processed, and prints every 100K objects (effectively, there is a very low probability it'll ever print stats). The reason for this bug is that I was previously printing stats for every new directory, and later decided it's nicer to print stats for large number of new "objects" (files or directories) instead. 
> This is a minor issue - and since I'm refactoring this I've also changed the minor retry logic to make code nicer and more readable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)