You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Guozhang Wang <gu...@linkedin.com> on 2013/11/19 00:30:24 UTC
Review Request 15659: Patch for KAFKA-1103
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15659/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1103
https://issues.apache.org/jira/browse/KAFKA-1103
Repository: kafka
Description
-------
KAFKA-1103.v1
Diffs
-----
core/src/main/scala/kafka/consumer/TopicFilter.scala cf3853b223095e1fe0921175c407a906828b8113
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala c0350cd05cf1b59866a1fedccbeb700b3e828d44
core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala a67c193df9f7cbfc52f75dc1b71dc017de1b5fe2
core/src/test/scala/unit/kafka/consumer/TopicFilterTest.scala 40a2bf7a9277eb5f94bc07b40d7726d81860cefc
Diff: https://reviews.apache.org/r/15659/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 15659: Incorporate Joel/Jun's comments,
MM system test passed
Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15659/#review29205
-----------------------------------------------------------
Ship it!
Looks good.
- Joel Koshy
On Nov. 20, 2013, 8:59 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15659/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2013, 8:59 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1103
> https://issues.apache.org/jira/browse/KAFKA-1103
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1103.v2
>
>
> Dummy
>
>
> KAFKA-1103.v1
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/consumer/TopicFilter.scala cf3853b223095e1fe0921175c407a906828b8113
> core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala c0350cd05cf1b59866a1fedccbeb700b3e828d44
> core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala a67c193df9f7cbfc52f75dc1b71dc017de1b5fe2
> core/src/test/scala/unit/kafka/consumer/TopicFilterTest.scala 40a2bf7a9277eb5f94bc07b40d7726d81860cefc
> system_test/migration_tool_testsuite/0.7/config/test-log4j.properties a3ae33f20e4b7cff87d8cf8368d0639b8bea73a6
>
> Diff: https://reviews.apache.org/r/15659/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 15659: Incorporate Joel/Jun's comments,
MM system test passed, rebased
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15659/#review29593
-----------------------------------------------------------
core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala
<https://reviews.apache.org/r/15659/#comment56989>
Can we improve this WARN? It implies that we will not shutdown the client, but we proceed with the shutdown anyways :)
- Neha Narkhede
On Nov. 21, 2013, 7:22 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15659/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2013, 7:22 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1103
> https://issues.apache.org/jira/browse/KAFKA-1103
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1103.v2
>
>
> Dummy
>
>
> KAFKA-1103.v1
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/consumer/TopicFilter.scala cf3853b223095e1fe0921175c407a906828b8113
> core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 6d0cfa665e90a168a70501a81f10fa4d3c7a7f22
> core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala a67c193df9f7cbfc52f75dc1b71dc017de1b5fe2
> core/src/test/scala/unit/kafka/consumer/TopicFilterTest.scala 40a2bf7a9277eb5f94bc07b40d7726d81860cefc
> system_test/migration_tool_testsuite/0.7/config/test-log4j.properties a3ae33f20e4b7cff87d8cf8368d0639b8bea73a6
>
> Diff: https://reviews.apache.org/r/15659/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 15659: Incorporate Joel/Jun's comments,
MM system test passed, rebased
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15659/
-----------------------------------------------------------
(Updated Nov. 21, 2013, 7:22 p.m.)
Review request for kafka.
Summary (updated)
-----------------
Incorporate Joel/Jun's comments, MM system test passed, rebased
Bugs: KAFKA-1103
https://issues.apache.org/jira/browse/KAFKA-1103
Repository: kafka
Description
-------
KAFKA-1103.v2
Dummy
KAFKA-1103.v1
Diffs (updated)
-----
core/src/main/scala/kafka/consumer/TopicFilter.scala cf3853b223095e1fe0921175c407a906828b8113
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 6d0cfa665e90a168a70501a81f10fa4d3c7a7f22
core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala a67c193df9f7cbfc52f75dc1b71dc017de1b5fe2
core/src/test/scala/unit/kafka/consumer/TopicFilterTest.scala 40a2bf7a9277eb5f94bc07b40d7726d81860cefc
system_test/migration_tool_testsuite/0.7/config/test-log4j.properties a3ae33f20e4b7cff87d8cf8368d0639b8bea73a6
Diff: https://reviews.apache.org/r/15659/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 15659: Incorporate Joel/Jun's comments,
MM system test passed
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15659/
-----------------------------------------------------------
(Updated Nov. 20, 2013, 8:59 p.m.)
Review request for kafka.
Summary (updated)
-----------------
Incorporate Joel/Jun's comments, MM system test passed
Bugs: KAFKA-1103
https://issues.apache.org/jira/browse/KAFKA-1103
Repository: kafka
Description (updated)
-------
KAFKA-1103.v2
Dummy
KAFKA-1103.v1
Diffs (updated)
-----
core/src/main/scala/kafka/consumer/TopicFilter.scala cf3853b223095e1fe0921175c407a906828b8113
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala c0350cd05cf1b59866a1fedccbeb700b3e828d44
core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala a67c193df9f7cbfc52f75dc1b71dc017de1b5fe2
core/src/test/scala/unit/kafka/consumer/TopicFilterTest.scala 40a2bf7a9277eb5f94bc07b40d7726d81860cefc
system_test/migration_tool_testsuite/0.7/config/test-log4j.properties a3ae33f20e4b7cff87d8cf8368d0639b8bea73a6
Diff: https://reviews.apache.org/r/15659/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 15659: Patch for KAFKA-1103
Posted by Guozhang Wang <gu...@linkedin.com>.
> On Nov. 20, 2013, 6:01 p.m., Jun Rao wrote:
> > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala, lines 769-770
> > <https://reviews.apache.org/r/15659/diff/1/?file=388148#file388148line769>
> >
> > topicFilter could be a black list too. So we need to fix the logged message.
Done.
- Guozhang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15659/#review29175
-----------------------------------------------------------
On Nov. 18, 2013, 11:30 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15659/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2013, 11:30 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1103
> https://issues.apache.org/jira/browse/KAFKA-1103
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1103.v1
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/consumer/TopicFilter.scala cf3853b223095e1fe0921175c407a906828b8113
> core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala c0350cd05cf1b59866a1fedccbeb700b3e828d44
> core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala a67c193df9f7cbfc52f75dc1b71dc017de1b5fe2
> core/src/test/scala/unit/kafka/consumer/TopicFilterTest.scala 40a2bf7a9277eb5f94bc07b40d7726d81860cefc
>
> Diff: https://reviews.apache.org/r/15659/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 15659: Patch for KAFKA-1103
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15659/#review29175
-----------------------------------------------------------
Looks good except for the following minor comment.
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
<https://reviews.apache.org/r/15659/#comment56316>
topicFilter could be a black list too. So we need to fix the logged message.
- Jun Rao
On Nov. 18, 2013, 11:30 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15659/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2013, 11:30 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1103
> https://issues.apache.org/jira/browse/KAFKA-1103
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1103.v1
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/consumer/TopicFilter.scala cf3853b223095e1fe0921175c407a906828b8113
> core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala c0350cd05cf1b59866a1fedccbeb700b3e828d44
> core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala a67c193df9f7cbfc52f75dc1b71dc017de1b5fe2
> core/src/test/scala/unit/kafka/consumer/TopicFilterTest.scala 40a2bf7a9277eb5f94bc07b40d7726d81860cefc
>
> Diff: https://reviews.apache.org/r/15659/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 15659: Patch for KAFKA-1103
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15659/#review29139
-----------------------------------------------------------
core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala
<https://reviews.apache.org/r/15659/#comment56271>
will do
core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala
<https://reviews.apache.org/r/15659/#comment56272>
will fix the typo, but I think it is still worth leaving it here in case zkClient is null (theoretically it will never be).
- Guozhang Wang
On Nov. 18, 2013, 11:30 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15659/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2013, 11:30 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1103
> https://issues.apache.org/jira/browse/KAFKA-1103
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1103.v1
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/consumer/TopicFilter.scala cf3853b223095e1fe0921175c407a906828b8113
> core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala c0350cd05cf1b59866a1fedccbeb700b3e828d44
> core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala a67c193df9f7cbfc52f75dc1b71dc017de1b5fe2
> core/src/test/scala/unit/kafka/consumer/TopicFilterTest.scala 40a2bf7a9277eb5f94bc07b40d7726d81860cefc
>
> Diff: https://reviews.apache.org/r/15659/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 15659: Patch for KAFKA-1103
Posted by Joel Koshy <jj...@gmail.com>.
> On Nov. 19, 2013, 9:48 p.m., Joel Koshy wrote:
> > Looks good to me except for minor comments. I'll leave open for now in case anyone else wants to review.
Also, could you run the mirror-maker system test suite to make sure there are no obvious issues?
- Joel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15659/#review29134
-----------------------------------------------------------
On Nov. 18, 2013, 11:30 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15659/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2013, 11:30 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1103
> https://issues.apache.org/jira/browse/KAFKA-1103
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1103.v1
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/consumer/TopicFilter.scala cf3853b223095e1fe0921175c407a906828b8113
> core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala c0350cd05cf1b59866a1fedccbeb700b3e828d44
> core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala a67c193df9f7cbfc52f75dc1b71dc017de1b5fe2
> core/src/test/scala/unit/kafka/consumer/TopicFilterTest.scala 40a2bf7a9277eb5f94bc07b40d7726d81860cefc
>
> Diff: https://reviews.apache.org/r/15659/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 15659: Patch for KAFKA-1103
Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15659/#review29134
-----------------------------------------------------------
Looks good to me except for minor comments. I'll leave open for now in case anyone else wants to review.
core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala
<https://reviews.apache.org/r/15659/#comment56262>
So the config is no longer required.
core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala
<https://reviews.apache.org/r/15659/#comment56263>
Typo in message; however, I think we can just drop the entire else block.
- Joel Koshy
On Nov. 18, 2013, 11:30 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15659/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2013, 11:30 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1103
> https://issues.apache.org/jira/browse/KAFKA-1103
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1103.v1
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/consumer/TopicFilter.scala cf3853b223095e1fe0921175c407a906828b8113
> core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala c0350cd05cf1b59866a1fedccbeb700b3e828d44
> core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala a67c193df9f7cbfc52f75dc1b71dc017de1b5fe2
> core/src/test/scala/unit/kafka/consumer/TopicFilterTest.scala 40a2bf7a9277eb5f94bc07b40d7726d81860cefc
>
> Diff: https://reviews.apache.org/r/15659/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>