[jira] [Updated] (OOZIE-2462) When calling ParamChecker.notNull() in CoordActionsIgnoreXCommand.java, "Action" should be passed instead of "Action cannot be null".

["abhishek bafna (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OOZIE-2462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

abhishek bafna updated OOZIE-2462:
----------------------------------
    Fix Version/s: 4.3.0

> When calling ParamChecker.notNull() in CoordActionsIgnoreXCommand.java, "Action" should be passed instead of "Action cannot be null".
> -------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OOZIE-2462
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2462
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Manjunath Ballur
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 4.3.0
>
>         Attachments: OOZIE-2462-001.patch, OOZIE-2462-002.patch, OOZIE-2462-002.patch
>
>
> In ParamChecker::notNull() method, if the passed object is null, then following exception is thrown:
>         if (obj == null) {
>             throw new IllegalArgumentException(name + " cannot be null");
>         }
> Here, "name" is the name of the object being checked.
> In "CoordActionsIgnoreXCommand::checkAllActionsStatus()" method, following piece of code calls "ParamChecker::notNull()" method:
>     ParamChecker.notNull(action, "Action cannot be null");
> The above statement should be changed to:
>     ParamChecker.notNull(action, "Action");
> With the current code, when "action" is null, then the message printed will be:
> "Action cannot be null cannot be null"
> "cannot be null" is printed twice.
> Hence, we need to remove "cannot be null" while calling "ParamChecker::notNull()" method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)