You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2014/05/10 23:55:44 UTC
[jira] [Commented] (LUCENE-5660) AnalyzingSuggester needs
reasonable limits on max suggestion length
[ https://issues.apache.org/jira/browse/LUCENE-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993595#comment-13993595 ]
ASF subversion and git services commented on LUCENE-5660:
---------------------------------------------------------
Commit 1593548 from [~mikemccand] in branch 'dev/trunk'
[ https://svn.apache.org/r1593548 ]
LUCENE-5660: add changs
> AnalyzingSuggester needs reasonable limits on max suggestion length
> -------------------------------------------------------------------
>
> Key: LUCENE-5660
> URL: https://issues.apache.org/jira/browse/LUCENE-5660
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Attachments: LUCENE-5660.patch
>
>
> Issues like LUCENE-5628 LUCENE-5659 are hacks around the problem that the AnalyzingSuggester allows automata to "explode".
> I don't think we should try to hack up the automata lib to the point its un-understandable to support this, since its designed for smaller automata such as queries and is appropriate for that.
> We should instead just set appropriate limits out of box so AnalyzingSuggester doesnt blow up.
> Remember this is a suggester, it needs to be fast. The fact that the automata lib blows up on stupid unit tests or whatever are doing this, instead of being silently slow, is a good thing.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org