You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/10 06:36:31 UTC
[GitHub] [shardingsphere] codecov-io commented on pull request #8512: Modify prevalidate and post validate method.
codecov-io commented on pull request #8512:
URL: https://github.com/apache/shardingsphere/pull/8512#issuecomment-742275594
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8512?src=pr&el=h1) Report
> Merging [#8512](https://codecov.io/gh/apache/shardingsphere/pull/8512?src=pr&el=desc) (02b1a4a) into [master](https://codecov.io/gh/apache/shardingsphere/commit/31fb74fd516b5064b0ceb70e62be58bfd2c6945a?el=desc) (31fb74f) will **decrease** coverage by `1.23%`.
> The diff coverage is `70.00%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/8512?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8512 +/- ##
============================================
- Coverage 73.46% 72.22% -1.24%
+ Complexity 603 602 -1
============================================
Files 1508 1545 +37
Lines 23905 24533 +628
Branches 4224 4328 +104
============================================
+ Hits 17561 17719 +158
- Misses 5184 5656 +472
+ Partials 1160 1158 -2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8512?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...tor/dml/impl/ShardingInsertStatementValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/8512/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS92YWxpZGF0b3IvZG1sL2ltcGwvU2hhcmRpbmdJbnNlcnRTdGF0ZW1lbnRWYWxpZGF0b3IuamF2YQ==) | `79.31% <0.00%> (-5.88%)` | `0.00 <0.00> (ø)` | |
| [...e/validator/dml/ShardingDMLStatementValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/8512/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS92YWxpZGF0b3IvZG1sL1NoYXJkaW5nRE1MU3RhdGVtZW50VmFsaWRhdG9yLmphdmE=) | `70.68% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...tor/dml/impl/ShardingSelectStatementValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/8512/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS92YWxpZGF0b3IvZG1sL2ltcGwvU2hhcmRpbmdTZWxlY3RTdGF0ZW1lbnRWYWxpZGF0b3IuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...a/executor/sql/execute/engine/raw/RawExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/8512/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9leGVjdXRlL2VuZ2luZS9yYXcvUmF3RXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (ø%)` | |
| [...initializer/impl/StandardBootstrapInitializer.java](https://codecov.io/gh/apache/shardingsphere/pull/8512/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9pbml0aWFsaXplci9pbXBsL1N0YW5kYXJkQm9vdHN0cmFwSW5pdGlhbGl6ZXIuamF2YQ==) | `66.66% <0.00%> (-33.34%)` | `1.00% <0.00%> (ø%)` | |
| [...caling/core/service/AbstractScalingJobService.java](https://codecov.io/gh/apache/shardingsphere/pull/8512/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zZXJ2aWNlL0Fic3RyYWN0U2NhbGluZ0pvYlNlcnZpY2UuamF2YQ==) | `58.62% <0.00%> (-29.62%)` | `1.00% <0.00%> (ø%)` | |
| [...dingsphere/scaling/core/utils/ScalingTaskUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/8512/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS91dGlscy9TY2FsaW5nVGFza1V0aWwuamF2YQ==) | `55.55% <0.00%> (-27.78%)` | `0.00% <0.00%> (ø%)` | |
| [...rdingsphere/scaling/core/utils/ReflectionUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/8512/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS91dGlscy9SZWZsZWN0aW9uVXRpbC5qYXZh) | `48.57% <0.00%> (-17.15%)` | `0.00% <0.00%> (ø%)` | |
| [...hardingsphere/scaling/mysql/MySQLScalingEntry.java](https://codecov.io/gh/apache/shardingsphere/pull/8512/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL015U1FMU2NhbGluZ0VudHJ5LmphdmE=) | `88.88% <0.00%> (-11.12%)` | `1.00% <0.00%> (ø%)` | |
| [...ere/scaling/postgresql/PostgreSQLScalingEntry.java](https://codecov.io/gh/apache/shardingsphere/pull/8512/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvcG9zdGdyZXNxbC9Qb3N0Z3JlU1FMU2NhbGluZ0VudHJ5LmphdmE=) | `88.88% <0.00%> (-11.12%)` | `1.00% <0.00%> (ø%)` | |
| ... and [187 more](https://codecov.io/gh/apache/shardingsphere/pull/8512/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8512?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8512?src=pr&el=footer). Last update [31fb74f...02b1a4a](https://codecov.io/gh/apache/shardingsphere/pull/8512?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org