[jira] [Comment Edited] (OAK-3621) Required property type not respected

["angela (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15002471#comment-15002471 ] 

angela edited comment on OAK-3621 at 11/13/15 1:59 PM:
-------------------------------------------------------

just had a quick look: IMO we have different problems here

- the required type is not validated in the {{TypeEditor}} (OAK-3624)
- the value conversion seems to violate the rules mandated by JSR 283
- the calculation of the applicable property definition is not always correct
- there seems to be inconsistency between changing the value of an existing property compared to adding a new property (maybe related to the issue before... didn't test everything).


was (Author: anchela):
just had a quick look: IMO we have different problems here

- the required type is not validated in the {{TypeEditor}}
- the value conversion seems to violate the rules mandated by JSR 283
- the calculation of the applicable property definition is not always correct
- there seems to be inconsistency between changing the value of an existing property compared to adding a new property (maybe related to the issue before... didn't test everything).

> Required property type not respected
> ------------------------------------
>
>                 Key: OAK-3621
>                 URL: https://issues.apache.org/jira/browse/OAK-3621
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core, jcr
>            Reporter: Antonio Sanso
>         Attachments: OAK-3621_test.patch, mixin_definition.png, property_type.png
>
>
> It seems like Section 7.1.5 Adding and Writing Properties of jsr 170 
> {code}
> 						Sets the specified (single value) property of this node
> to the specified value. If the property does not yet
> exist, it is created. The property type of the property
> will be that specified by the node type of this node.
> 						If the property type of the supplied Value object is
> different from that required, then a best-effort
> conversion is attempted. If the conversion fails, a
> ValueFormatException is thrown. If another error
> occurs, a RepositoryException is thrown.
> 						If the node type of this node does not indicate a
> specific property type, then the property type of the
> supplied Value object is used and if the property
> already exists (has previously been set) it assumes
> both the new value and new property type.
> {code}
> is not respected.In the provided screenshots you can see a mixin definition having a long property. But the property type in the creation node is Boolean



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)