You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Jeff Hodges (JIRA)" <ji...@apache.org> on 2009/03/18 10:23:50 UTC
[jira] Created: (BUILDR-269) rspec bdd is broken
rspec bdd is broken
-------------------
Key: BUILDR-269
URL: https://issues.apache.org/jira/browse/BUILDR-269
Project: Buildr
Issue Type: Bug
Components: Test frameworks
Reporter: Jeff Hodges
Fix For: 1.3.4
There a multitude of bugs in the running of rspec in buildr in the current github repository.
These patches fix the issues with:
* mkdir_p being called without being called on FileUtils
* a call is made to Error.dump_yaml with only one argument instead of two
* Kernel.gem is a private method, and this patch changes the calls to it into Kernel#send calls that gets around it
* for yucks, I made the backtrace that come back on errors nicer by turning it into a pretty string. (we should probably not have this stack trace and the usual rspec --trace one being returned at the same time like it does now. it's pretty confusing.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-269) rspec bdd is broken
Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683055#action_12683055 ]
Assaf Arkin commented on BUILDR-269:
------------------------------------
any idea how to spec/test this, so it doesn't break again?
> rspec bdd is broken
> -------------------
>
> Key: BUILDR-269
> URL: https://issues.apache.org/jira/browse/BUILDR-269
> Project: Buildr
> Issue Type: Bug
> Components: Test frameworks
> Reporter: Jeff Hodges
> Fix For: 1.3.4
>
> Attachments: 0001-Kernel.gem-is-a-private-method-on-Kernel-and-it-cann.patch, 0002-mkdir_p-does-not-exist-except-on-FileUtils-and-dump_.patch, 0003-adding-a-join-n-on-to-the-returned-backtrace-to.patch
>
>
> There a multitude of bugs in the running of rspec in buildr in the current github repository.
> These patches fix the issues with:
> * mkdir_p being called without being called on FileUtils
> * a call is made to Error.dump_yaml with only one argument instead of two
> * Kernel.gem is a private method, and this patch changes the calls to it into Kernel#send calls that gets around it
> * for yucks, I made the backtrace that come back on errors nicer by turning it into a pretty string. (we should probably not have this stack trace and the usual rspec --trace one being returned at the same time like it does now. it's pretty confusing.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (BUILDR-269) rspec bdd is broken
Posted by "Jeff Hodges (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682967#action_12682967 ]
Jeff Hodges edited comment on BUILDR-269 at 3/18/09 2:27 AM:
-------------------------------------------------------------
Kernel.gem is a private method patch
was (Author: jmhodges):
Kernel.gem is a private method bug
> rspec bdd is broken
> -------------------
>
> Key: BUILDR-269
> URL: https://issues.apache.org/jira/browse/BUILDR-269
> Project: Buildr
> Issue Type: Bug
> Components: Test frameworks
> Reporter: Jeff Hodges
> Fix For: 1.3.4
>
> Attachments: 0001-Kernel.gem-is-a-private-method-on-Kernel-and-it-cann.patch, 0002-mkdir_p-does-not-exist-except-on-FileUtils-and-dump_.patch, 0003-adding-a-join-n-on-to-the-returned-backtrace-to.patch
>
>
> There a multitude of bugs in the running of rspec in buildr in the current github repository.
> These patches fix the issues with:
> * mkdir_p being called without being called on FileUtils
> * a call is made to Error.dump_yaml with only one argument instead of two
> * Kernel.gem is a private method, and this patch changes the calls to it into Kernel#send calls that gets around it
> * for yucks, I made the backtrace that come back on errors nicer by turning it into a pretty string. (we should probably not have this stack trace and the usual rspec --trace one being returned at the same time like it does now. it's pretty confusing.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (BUILDR-269) rspec bdd is broken
Posted by "Victor Hugo Borja (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Victor Hugo Borja reassigned BUILDR-269:
----------------------------------------
Assignee: Victor Hugo Borja
> rspec bdd is broken
> -------------------
>
> Key: BUILDR-269
> URL: https://issues.apache.org/jira/browse/BUILDR-269
> Project: Buildr
> Issue Type: Bug
> Components: Test frameworks
> Reporter: Jeff Hodges
> Assignee: Victor Hugo Borja
> Fix For: 1.3.4
>
> Attachments: 0001-Kernel.gem-is-a-private-method-on-Kernel-and-it-cann.patch, 0002-mkdir_p-does-not-exist-except-on-FileUtils-and-dump_.patch, 0003-adding-a-join-n-on-to-the-returned-backtrace-to.patch
>
>
> There a multitude of bugs in the running of rspec in buildr in the current github repository.
> These patches fix the issues with:
> * mkdir_p being called without being called on FileUtils
> * a call is made to Error.dump_yaml with only one argument instead of two
> * Kernel.gem is a private method, and this patch changes the calls to it into Kernel#send calls that gets around it
> * for yucks, I made the backtrace that come back on errors nicer by turning it into a pretty string. (we should probably not have this stack trace and the usual rspec --trace one being returned at the same time like it does now. it's pretty confusing.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (BUILDR-269) rspec bdd is broken
Posted by "Jeff Hodges (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682969#action_12682969 ]
Jeff Hodges edited comment on BUILDR-269 at 3/18/09 2:27 AM:
-------------------------------------------------------------
better looking backtrace patch
was (Author: jmhodges):
better looking backtrace
> rspec bdd is broken
> -------------------
>
> Key: BUILDR-269
> URL: https://issues.apache.org/jira/browse/BUILDR-269
> Project: Buildr
> Issue Type: Bug
> Components: Test frameworks
> Reporter: Jeff Hodges
> Fix For: 1.3.4
>
> Attachments: 0001-Kernel.gem-is-a-private-method-on-Kernel-and-it-cann.patch, 0002-mkdir_p-does-not-exist-except-on-FileUtils-and-dump_.patch, 0003-adding-a-join-n-on-to-the-returned-backtrace-to.patch
>
>
> There a multitude of bugs in the running of rspec in buildr in the current github repository.
> These patches fix the issues with:
> * mkdir_p being called without being called on FileUtils
> * a call is made to Error.dump_yaml with only one argument instead of two
> * Kernel.gem is a private method, and this patch changes the calls to it into Kernel#send calls that gets around it
> * for yucks, I made the backtrace that come back on errors nicer by turning it into a pretty string. (we should probably not have this stack trace and the usual rspec --trace one being returned at the same time like it does now. it's pretty confusing.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (BUILDR-269) rspec bdd is broken
Posted by "Jeff Hodges (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682968#action_12682968 ]
Jeff Hodges edited comment on BUILDR-269 at 3/18/09 2:27 AM:
-------------------------------------------------------------
FileUtils.mkdir_p and dump_yaml arg patch
was (Author: jmhodges):
FileUtils.mkdir_p and dump_yaml arg bug
> rspec bdd is broken
> -------------------
>
> Key: BUILDR-269
> URL: https://issues.apache.org/jira/browse/BUILDR-269
> Project: Buildr
> Issue Type: Bug
> Components: Test frameworks
> Reporter: Jeff Hodges
> Fix For: 1.3.4
>
> Attachments: 0001-Kernel.gem-is-a-private-method-on-Kernel-and-it-cann.patch, 0002-mkdir_p-does-not-exist-except-on-FileUtils-and-dump_.patch, 0003-adding-a-join-n-on-to-the-returned-backtrace-to.patch
>
>
> There a multitude of bugs in the running of rspec in buildr in the current github repository.
> These patches fix the issues with:
> * mkdir_p being called without being called on FileUtils
> * a call is made to Error.dump_yaml with only one argument instead of two
> * Kernel.gem is a private method, and this patch changes the calls to it into Kernel#send calls that gets around it
> * for yucks, I made the backtrace that come back on errors nicer by turning it into a pretty string. (we should probably not have this stack trace and the usual rspec --trace one being returned at the same time like it does now. it's pretty confusing.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-269) rspec bdd is broken
Posted by "Jeff Hodges (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeff Hodges updated BUILDR-269:
-------------------------------
Attachment: 0001-Kernel.gem-is-a-private-method-on-Kernel-and-it-cann.patch
Kernel.gem is a private method bug
> rspec bdd is broken
> -------------------
>
> Key: BUILDR-269
> URL: https://issues.apache.org/jira/browse/BUILDR-269
> Project: Buildr
> Issue Type: Bug
> Components: Test frameworks
> Reporter: Jeff Hodges
> Fix For: 1.3.4
>
> Attachments: 0001-Kernel.gem-is-a-private-method-on-Kernel-and-it-cann.patch, 0002-mkdir_p-does-not-exist-except-on-FileUtils-and-dump_.patch
>
>
> There a multitude of bugs in the running of rspec in buildr in the current github repository.
> These patches fix the issues with:
> * mkdir_p being called without being called on FileUtils
> * a call is made to Error.dump_yaml with only one argument instead of two
> * Kernel.gem is a private method, and this patch changes the calls to it into Kernel#send calls that gets around it
> * for yucks, I made the backtrace that come back on errors nicer by turning it into a pretty string. (we should probably not have this stack trace and the usual rspec --trace one being returned at the same time like it does now. it's pretty confusing.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-269) rspec bdd is broken
Posted by "Jeff Hodges (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683285#action_12683285 ]
Jeff Hodges commented on BUILDR-269:
------------------------------------
Well, the problem that led me to all of this was result.yaml not being created after a run. We could have a test app that has a set of specs that would be run and have the existence and consistency of the result.yaml checked after it finished. However, I can't figure out how buildr takes in the test task and turns that into executing runner.rb, so I'm at a loss. We could also just have it run against specific spec files that would do try to do various breaking things, but, again, I'm not sure how that works with the current runner.rb architecture.
> rspec bdd is broken
> -------------------
>
> Key: BUILDR-269
> URL: https://issues.apache.org/jira/browse/BUILDR-269
> Project: Buildr
> Issue Type: Bug
> Components: Test frameworks
> Reporter: Jeff Hodges
> Fix For: 1.3.4
>
> Attachments: 0001-Kernel.gem-is-a-private-method-on-Kernel-and-it-cann.patch, 0002-mkdir_p-does-not-exist-except-on-FileUtils-and-dump_.patch, 0003-adding-a-join-n-on-to-the-returned-backtrace-to.patch
>
>
> There a multitude of bugs in the running of rspec in buildr in the current github repository.
> These patches fix the issues with:
> * mkdir_p being called without being called on FileUtils
> * a call is made to Error.dump_yaml with only one argument instead of two
> * Kernel.gem is a private method, and this patch changes the calls to it into Kernel#send calls that gets around it
> * for yucks, I made the backtrace that come back on errors nicer by turning it into a pretty string. (we should probably not have this stack trace and the usual rspec --trace one being returned at the same time like it does now. it's pretty confusing.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-269) rspec bdd is broken
Posted by "Jeff Hodges (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeff Hodges updated BUILDR-269:
-------------------------------
Attachment: 0003-adding-a-join-n-on-to-the-returned-backtrace-to.patch
better looking backtrace
> rspec bdd is broken
> -------------------
>
> Key: BUILDR-269
> URL: https://issues.apache.org/jira/browse/BUILDR-269
> Project: Buildr
> Issue Type: Bug
> Components: Test frameworks
> Reporter: Jeff Hodges
> Fix For: 1.3.4
>
> Attachments: 0001-Kernel.gem-is-a-private-method-on-Kernel-and-it-cann.patch, 0002-mkdir_p-does-not-exist-except-on-FileUtils-and-dump_.patch, 0003-adding-a-join-n-on-to-the-returned-backtrace-to.patch
>
>
> There a multitude of bugs in the running of rspec in buildr in the current github repository.
> These patches fix the issues with:
> * mkdir_p being called without being called on FileUtils
> * a call is made to Error.dump_yaml with only one argument instead of two
> * Kernel.gem is a private method, and this patch changes the calls to it into Kernel#send calls that gets around it
> * for yucks, I made the backtrace that come back on errors nicer by turning it into a pretty string. (we should probably not have this stack trace and the usual rspec --trace one being returned at the same time like it does now. it's pretty confusing.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-269) rspec bdd is broken
Posted by "Jeff Hodges (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeff Hodges updated BUILDR-269:
-------------------------------
Attachment: 0002-mkdir_p-does-not-exist-except-on-FileUtils-and-dump_.patch
FileUtils.mkdir_p and dump_yaml arg bug
> rspec bdd is broken
> -------------------
>
> Key: BUILDR-269
> URL: https://issues.apache.org/jira/browse/BUILDR-269
> Project: Buildr
> Issue Type: Bug
> Components: Test frameworks
> Reporter: Jeff Hodges
> Fix For: 1.3.4
>
> Attachments: 0001-Kernel.gem-is-a-private-method-on-Kernel-and-it-cann.patch, 0002-mkdir_p-does-not-exist-except-on-FileUtils-and-dump_.patch
>
>
> There a multitude of bugs in the running of rspec in buildr in the current github repository.
> These patches fix the issues with:
> * mkdir_p being called without being called on FileUtils
> * a call is made to Error.dump_yaml with only one argument instead of two
> * Kernel.gem is a private method, and this patch changes the calls to it into Kernel#send calls that gets around it
> * for yucks, I made the backtrace that come back on errors nicer by turning it into a pretty string. (we should probably not have this stack trace and the usual rspec --trace one being returned at the same time like it does now. it's pretty confusing.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BUILDR-269) rspec bdd is broken
Posted by "Victor Hugo Borja (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Victor Hugo Borja resolved BUILDR-269.
--------------------------------------
Resolution: Fixed
Thanks, applied, also added an example to expose this failure.
> rspec bdd is broken
> -------------------
>
> Key: BUILDR-269
> URL: https://issues.apache.org/jira/browse/BUILDR-269
> Project: Buildr
> Issue Type: Bug
> Components: Test frameworks
> Reporter: Jeff Hodges
> Assignee: Victor Hugo Borja
> Fix For: 1.3.4
>
> Attachments: 0001-Kernel.gem-is-a-private-method-on-Kernel-and-it-cann.patch, 0002-mkdir_p-does-not-exist-except-on-FileUtils-and-dump_.patch, 0003-adding-a-join-n-on-to-the-returned-backtrace-to.patch
>
>
> There a multitude of bugs in the running of rspec in buildr in the current github repository.
> These patches fix the issues with:
> * mkdir_p being called without being called on FileUtils
> * a call is made to Error.dump_yaml with only one argument instead of two
> * Kernel.gem is a private method, and this patch changes the calls to it into Kernel#send calls that gets around it
> * for yucks, I made the backtrace that come back on errors nicer by turning it into a pretty string. (we should probably not have this stack trace and the usual rspec --trace one being returned at the same time like it does now. it's pretty confusing.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.