You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/05/10 08:07:52 UTC
[GitHub] [lucene] jpountz opened a new pull request, #876: LUCENE-9356: Change test to detect mismatched checksums instead of byte flips.
jpountz opened a new pull request, #876:
URL: https://github.com/apache/lucene/pull/876
This makes the test more robust and gives a good sense of whether file formats
are implementing `checkIntegrity` correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz merged pull request #876: LUCENE-9356: Change test to detect mismatched checksums instead of byte flips.
Posted by GitBox <gi...@apache.org>.
jpountz merged PR #876:
URL: https://github.com/apache/lucene/pull/876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz commented on pull request #876: LUCENE-9356: Change test to detect mismatched checksums instead of byte flips.
Posted by GitBox <gi...@apache.org>.
jpountz commented on PR #876:
URL: https://github.com/apache/lucene/pull/876#issuecomment-1123706148
I removed the dependency on LineFileDocs. Interestingly, this test caught an issue with vectors, which don't close index inputs on all paths. cc @mayya-sharipova since there are in-progress PRs that make changes to vectors formats
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mayya-sharipova commented on pull request #876: LUCENE-9356: Change test to detect mismatched checksums instead of byte flips.
Posted by GitBox <gi...@apache.org>.
mayya-sharipova commented on PR #876:
URL: https://github.com/apache/lucene/pull/876#issuecomment-1128871222
Thanks Adrien for catching errors with vector files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #876: LUCENE-9356: Change test to detect mismatched checksums instead of byte flips.
Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #876:
URL: https://github.com/apache/lucene/pull/876#issuecomment-1122257235
do we really need the linefiledocs? If the test has rare failures, we'll want to reproduce them.
practically, linefiledocs just prevents reproducibility (uses a different file in CI than developers use, etc). I'd avoid it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org