You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@fineract.apache.org by Aleksandar Vidakovic <ch...@monkeysintown.com> on 2022/07/25 14:13:35 UTC

PR #2452

Hi Arnold and Hemant,

... I think the PR is not correct:

   - @Setter is missing (we said no more immutability, because of dev
   experience)
   - @NoArgsConstructor(access = AccessLevel.PROTECTED) is against the JPA
   spec (requires a public no args constructor
   - if the constructor with parameters is relatively easy to replace
   by @RequiredArgsConstructor then we should do this (probably order of
   parameters needs to be refactored

@Hemant Gupta <gu...@gmail.com> please check the documents and
notes again we created.

Cheers,

Aleks

Re: PR #2452

Posted by Aleksandar Vidakovic <ch...@monkeysintown.com>.

... concerning @Setter... I'll update a little document on that subject...
but the short version is: we can't use @Data on JPA entity classes (the
data/DTO classes have no Lombok restrictions). I'll send out the doc with
all important caveats that we have (so far) soon.

FYI

On Mon, Jul 25, 2022 at 5:54 PM Arnold Galovics <ar...@apache.org> wrote:

> Thanks Aleks for bringing this up.
>
> Let me reflect on your points:
> 1. No need for the @Setter annotation since @Data takes care of it
> 2. Good point, for some reason I didn't realize that.
> 3. Agreed.
>
> Best,
> Arnold
>
> On Mon, Jul 25, 2022 at 4:14 PM Aleksandar Vidakovic <
> cheetah@monkeysintown.com> wrote:
>
>> Hi Arnold and Hemant,
>>
>> ... I think the PR is not correct:
>>
>>    - @Setter is missing (we said no more immutability, because of dev
>>    experience)
>>    - @NoArgsConstructor(access = AccessLevel.PROTECTED) is against the
>>    JPA spec (requires a public no args constructor
>>    - if the constructor with parameters is relatively easy to replace
>>    by @RequiredArgsConstructor then we should do this (probably order of
>>    parameters needs to be refactored
>>
>> @Hemant Gupta <gu...@gmail.com> please check the documents and
>> notes again we created.
>>
>> Cheers,
>>
>> Aleks
>>
>

Re: PR #2452

Posted by Arnold Galovics <ar...@apache.org>.

Thanks Aleks for bringing this up.

Let me reflect on your points:
1. No need for the @Setter annotation since @Data takes care of it
2. Good point, for some reason I didn't realize that.
3. Agreed.

Best,
Arnold

On Mon, Jul 25, 2022 at 4:14 PM Aleksandar Vidakovic <
cheetah@monkeysintown.com> wrote:

> Hi Arnold and Hemant,
>
> ... I think the PR is not correct:
>
>    - @Setter is missing (we said no more immutability, because of dev
>    experience)
>    - @NoArgsConstructor(access = AccessLevel.PROTECTED) is against the
>    JPA spec (requires a public no args constructor
>    - if the constructor with parameters is relatively easy to replace
>    by @RequiredArgsConstructor then we should do this (probably order of
>    parameters needs to be refactored
>
> @Hemant Gupta <gu...@gmail.com> please check the documents and
> notes again we created.
>
> Cheers,
>
> Aleks
>