[GitHub] [airflow] dstandish commented on pull request #26260: Implement fast insert for mysql and sqlite

[GitBox <gi...@apache.org>]

dstandish commented on PR #26260:
URL: https://github.com/apache/airflow/pull/26260#issuecomment-1256675881

   > @potiuk This is faster as it is running one query with multiple values with (the db-specific equivalent of) `ON CONFLICT DO NOTHING`, where as the slow path takes a save point before each row, tries to insert the row, and on exception rolls back to the save point.
   > 
   > So fast path is faster because it's one query, not n, and doesn't involve exceptions (py) or savepoints (db) side!
   > 
   > @dstandish Can you convert ^^ to a code comment in appropriate place?
   
   sure thing, just holding off on merging this one until event timestamp one goes in, then will have to rebase and resolve conflicts


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org