You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Laszlo Gaal (Code Review)" <ge...@cloudera.org> on 2018/02/05 09:50:49 UTC

[native-toolchain-CR] Quiet down file transfers, rename target platform variable

Hello Tim Armstrong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9149

to look at the new patch set (#2).

Change subject: Quiet down file transfers, rename target platform variable
......................................................................

Quiet down file transfers, rename target platform variable

1. File download with wget and maven upload all have verbose progress
indicators. This increases noise in the build logs making it hard
to navigate to relevant details.

This patch:
- changes wget to use a less chatty progress bar
- changes maven upload to batch mode and bumps log level to warnings
  or worse
- tells "aws s3 cp" to report errors only, adding an explicit echo to
  report file copy source and estination.

2. When the toolchain is built in an automated environment (e.g. using
a Jenkins job), the build target platform identifier is communicated
in an environment variable. This patch renames this variable to
BUILD_TARGET_LABEL to untangle it from Jenkins-defined variables and
to make its role more explicit.

Tested by rebuilding the toolchain with the new script, using
a conforming Jenkins job; all artifacts were prodiced with correct
package name suffixes. Results are stored at:
s3://impala-toolchain-test/build/33-a25ad7b25c/

Change-Id: Iaa4349a8ae0ab5bde2dabf5ff65db0f2db4b9ba9
---
M functions.sh
M init.sh
2 files changed, 17 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/49/9149/2
-- 
To view, visit http://gerrit.cloudera.org:8080/9149
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa4349a8ae0ab5bde2dabf5ff65db0f2db4b9ba9
Gerrit-Change-Number: 9149
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>