[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39081: [SPARK-41538][SQL] Metadata column should be appended at the end of project list

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on code in PR #39081:
URL: https://github.com/apache/spark/pull/39081#discussion_r1050361696


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -1016,7 +1016,7 @@ class Analyzer(override val catalogManager: CatalogManager)
       case s: ExposesMetadataColumns => s.withMetadataColumns()
       case p: Project =>
         val newProj = p.copy(
-          projectList = p.metadataOutput ++ p.projectList,
+          projectList = p.projectList ++ p.metadataOutput,

Review Comment:
   Does this cause any user-facing query result change? I guess it's not.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org