You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by bu...@apache.org on 2007/03/18 10:15:49 UTC

DO NOT REPLY [Bug 41880] New: - Add content-type filtering to HTTP Proxy Server

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41880>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41880

           Summary: Add content-type filtering to HTTP Proxy Server
           Product: JMeter
           Version: 2.2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: HTTP
        AssignedTo: jmeter-dev@jakarta.apache.org
        ReportedBy: alf@i100.no


Add include and exclude filters for content-type, to control what gets added to
the test plan.

Also, restructure the GUI slightly, to make it easier to understand.
I propose to use some vertical panels, with title strings, to group related items.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 41880] - Add content-type filtering to HTTP Proxy Server

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41880>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41880


sebb@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From sebb@apache.org  2007-03-18 16:38 -------
Thanks!

The JMeterUtils.getProperty() calls seem fine.


The code has been added to SVN.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 41880] - Add content-type filtering to HTTP Proxy Server

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41880>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41880





------- Additional Comments From alf@i100.no  2007-03-18 02:32 -------
Created an attachment (id=19731)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=19731&action=view)
Suggested patch

This suggested patch adds content-type filtering.
It also supports to get default content type filters to use from the properties
file. I think that solves bug 32184, because now it is easy to specify what
static content you want to avoid in the test plan.

I'm not quite sure that the following lines are correct :
// Default value
contentTypeInclude.setText(JMeterUtils.getProperty("proxy.content_type_include"));


and

// Default value
contentTypeExclude.setText(JMeterUtils.getProperty("proxy.content_type_exclude"));


So please check if this is the correct way of picking up default values from
the properties file.

I have also restructured the GUI slightly from the fix for bug 41876. I have
moved the "controller" and "group" settings inside the "Test plan content"
group. And I have used VerticalPanel with titles, which I think makes it look
nice. Have a look, and apply that GUI change if you like it.

I have also added resource strings which was missed in fix for bug 41876.

I am also using the resource string from the HTTPSamplerGui for the options
that control the HTTPSamplerGUI, instead of having separate strings for the
same thing as proxy_* in the resource files. So I have removed
"proxy_usekeepalive".

And I have added "URL" prefix to the value of patterns_to_exclude,
patterns_to_include in all languages, because I think that makes it more clear
what the filer is applied against. Feel free to ditch that change.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 41880] - Add content-type filtering to HTTP Proxy Server

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41880>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41880





------- Additional Comments From alf@i100.no  2007-03-18 03:15 -------
Created an attachment (id=19732)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=19732&action=view)
Suggested patch with unit test

This patch contains some simple unit tests for the filtering on content-type

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org