You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "anshuksi282-ksolves (via GitHub)" <gi...@apache.org> on 2026/01/15 13:02:08 UTC

[PR] Fix: Enable descending sort for Start Date in Task Instances view [airflow]

anshuksi282-ksolves opened a new pull request, #60584:
URL: https://github.com/apache/airflow/pull/60584

   ### Description
   This PR addresses issue #60576. 
   
   Currently, the Start Date column in the Task Instances view does not toggle to a descending sort when clicked. It only toggles between unsorted and ascending. This behavior is misleading because the backend correctly supports descending sort (verified by manually adding ?sort=-start_date to the URL).
   
   The issue was caused by the missing explicit id in the column definition, which prevented TanStack Table from correctly mapping the sorting state for the complex cell renderer used in the Start Date column.
   
   #### Changes introduced:
   `TaskInstances.tsx`: Added an explicit `id: "start_date"` to the column definition to ensure proper state mapping during sorting toggles.
   
   `TaskInstances.tsx`: Added `enableSorting: true` to the Start Date column to ensure the full sorting cycle (**Ascending -> Descending -> None**) is active.
   
   
   ---
   
   * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix: Enable descending sort for Start Date in Task Instances view [airflow]

Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #60584:
URL: https://github.com/apache/airflow/pull/60584#issuecomment-3756754173

   I tested and id is still not the fix.
   
   I did a different fix here: https://github.com/apache/airflow/pull/60609


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix: Enable descending sort for Start Date in Task Instances view [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun closed pull request #60584: Fix: Enable descending sort for Start Date in Task Instances view
URL: https://github.com/apache/airflow/pull/60584


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix: Enable descending sort for Start Date in Task Instances view [airflow]

Posted by "anshuksi282-ksolves (via GitHub)" <gi...@apache.org>.
anshuksi282-ksolves commented on PR #60584:
URL: https://github.com/apache/airflow/pull/60584#issuecomment-3756520942

   "Hi @pierrejeambrun, since @bbovenzi has reopened the original issue (#60576) and confirmed that there is an 'intermittent' sorting issue, could we please reopen this PR?
   
   My change adds an explicit id to the column. In TanStack Table, when using custom cell renderers (like the Link and Time components used here), providing an explicit id is a recommended practice to ensure the sorting state remains stable and consistent. This might be exactly what's needed to fix the intermittent behavior observed."


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org