You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/12/09 19:08:36 UTC

[GitHub] [nifi] exceptionfactory opened a new pull request, #6774: NIFI-10958 Adjust Script Engine handling to avoid errors on Java 17

exceptionfactory opened a new pull request, #6774:
URL: https://github.com/apache/nifi/pull/6774

   # Summary
   
   [NIFI-10958](https://issues.apache.org/jira/browse/NIFI-10958) Adjusts Script Engine property handling in `ScriptingComponentsHelper` to avoid exceptions on Java 17 during documentation generation. Additional work is necessary to support ECMAScript and the Nashorn engine on Java 17, but introduced an empty check during the Script Engine introspection process avoids complete documentation generation failures.
   
   Current unit tests for `createResources()` work on Java 17 because the test environment has available classes.
   
   Further work on ECMAScript support using the Nashorn engine dependency on Java 17 is described in [NIFI-9383](https://issues.apache.org/jira/browse/NIFI-9383).
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
     - [ ] JDK 8
     - [ ] JDK 11
     - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] mattyb149 commented on pull request #6774: NIFI-10958 Adjust Script Engine handling to avoid errors on Java 17

Posted by GitBox <gi...@apache.org>.
mattyb149 commented on PR #6774:
URL: https://github.com/apache/nifi/pull/6774#issuecomment-1347381540

   +1 LGTM, thanks for the improvement! Merging to main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] mattyb149 closed pull request #6774: NIFI-10958 Adjust Script Engine handling to avoid errors on Java 17

Posted by GitBox <gi...@apache.org>.
mattyb149 closed pull request #6774: NIFI-10958 Adjust Script Engine handling to avoid errors on Java 17
URL: https://github.com/apache/nifi/pull/6774


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org