You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/14 05:19:27 UTC
[GitHub] [pulsar] nodece opened a new pull request, #15270: [improve][metadata] Add tls config for etcd client
nodece opened a new pull request, #15270:
URL: https://github.com/apache/pulsar/pull/15270
Signed-off-by: Zixuan Liu <no...@gmail.com>
Fixes #15205
### Motivation
The etcd metadata doesn't support tls config.
### Modifications
- Add tls config for etcd metadata store
- Add `metadataStoreConfigPath ` to `broker.conf` and `standalone.conf`
- Add `README.md` for etcd test directory
### Verifying this change
- [x] Make sure that the change passes the CI checks.
- Added tls config test
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [x] `doc-required` - Update `metadataStoreConfigPath` description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #15270: [improve][metadata] Add tls config for etcd client
Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #15270:
URL: https://github.com/apache/pulsar/pull/15270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on pull request #15270: [improve][metadata] Add tls config for etcd client
Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #15270:
URL: https://github.com/apache/pulsar/pull/15270#issuecomment-1188534300
### Doc status update
Besides PR#16463 mentioning the configs, @nodece will submit a follow-up PR to add docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #15270: [improve][metadata] Add tls config for etcd client
Posted by GitBox <gi...@apache.org>.
nodece commented on PR #15270:
URL: https://github.com/apache/pulsar/pull/15270#issuecomment-1120213987
> @nodece Please open a separate PR to add a document for the new configurations, and it's better to provide a config template under the `conf` directory.
Thanks for your point, I'll open a new PR to do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyuanpeng commented on pull request #15270: [improve][metadata] Add tls config for etcd client
Posted by GitBox <gi...@apache.org>.
liangyuanpeng commented on PR #15270:
URL: https://github.com/apache/pulsar/pull/15270#issuecomment-1133831454
@Technoboy- PTAL,Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #15270: [improve][metadata] Add tls config for etcd client
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on PR #15270:
URL: https://github.com/apache/pulsar/pull/15270#issuecomment-1120213065
@nodece Please open a separate PR to add a document for the new configurations, and it's better to provide a config template under the `conf` directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #15270: [improve][metadata] Add tls config for etcd client
Posted by GitBox <gi...@apache.org>.
nodece commented on PR #15270:
URL: https://github.com/apache/pulsar/pull/15270#issuecomment-1112895187
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #15270: [improve][metadata] Add tls config for etcd client
Posted by GitBox <gi...@apache.org>.
nodece commented on PR #15270:
URL: https://github.com/apache/pulsar/pull/15270#issuecomment-1112895085
/pulsarbot rereun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #15270: [improve][metadata] Add tls config for etcd client
Posted by GitBox <gi...@apache.org>.
Technoboy- closed pull request #15270: [improve][metadata] Add tls config for etcd client
URL: https://github.com/apache/pulsar/pull/15270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #15270: [improve][metadata] Add tls config for etcd client
Posted by GitBox <gi...@apache.org>.
nodece commented on PR #15270:
URL: https://github.com/apache/pulsar/pull/15270#issuecomment-1106545715
> I think the test should use the config file, it can test the whole logic and also demonstrate how to config.
This test includes this, you can check [this](https://github.com/apache/pulsar/pull/15270/files#diff-a0e5839b037c6eafba3bd343c5de940112d46a3c82cfc51e4fd0db44755247f3R44).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org