You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by Alain-Bearez <gi...@git.apache.org> on 2017/09/26 11:43:53 UTC

[GitHub] poi pull request #72: Define XDDF user model for shape properties to be shar...

GitHub user Alain-Bearez opened a pull request:

    https://github.com/apache/poi/pull/72

    Define XDDF user model for shape properties to be shared between XSSF and XSLF

    This pull request is branched from the `xddf-usermodel` branch (pull request #68).
    
    The main goal of this work is to provide a user model API in order to handle the shape properties without using underlying xmlbeans objects and interfaces. Among others, handling properties related to colors is made simpler by returning and accepting an abstract XDDFColor, which has six distinct implementations, where the developers were required to check whether or not one of the six properties was set.
    
    What is left to be done:
    - refactor XSLFColor and XSSFColor to make use of the new shareable code;
    - deprecate methods that return xmlbeans objects where a user model object now exists.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cuali/poi xddf-shape-properties

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/poi/pull/72.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #72
    
----
commit 359409443c48140583fc00529597274b6252ce0e
Author: Alain FAGOT BEAREZ <ab...@for-scala.it>
Date:   2017-06-01T06:34:07Z

    rework XSLFChart examples, hiding underlying internal interface

commit 94c6be98e69ff89a41372a277af523bb21983449
Author: Alain FAGOT BEAREZ <ab...@for-scala.it>
Date:   2017-05-26T07:30:07Z

    define a user model for chart axes (inspired by XSSFChartAxis)

commit 2ded4f39388cb5767d39d2148b4f4b3e31d3bf02
Author: Alain FAGOT BEAREZ <ab...@for-scala.it>
Date:   2017-06-01T08:09:06Z

    define user model for pie and bar charts data series (inspired by XSSF)

commit 748c4805cfe4eb5492d98f4ee53eb74d4849ba59
Author: Alain FAGOT BEAREZ <ab...@for-scala.it>
Date:   2017-08-01T05:44:44Z

    duplicate charts and workbooks while importing content from other slide

commit c8969110f803f89bca44e0aee1debf6687fc8c32
Author: Alain FAGOT BEAREZ <ab...@for-scala.it>
Date:   2017-07-04T06:56:19Z

    join efforts between XSSF charts and XSLF charts into XDDF DrawingML

commit 9d8fcfb599ef72ae764fa15432c943ae5f6296e2
Author: Alain FAGOT BEAREZ <ab...@for-scala.it>
Date:   2017-08-08T21:53:26Z

    enable more than one data series per chart

commit 993a46114cd1635d6147e0d5e48cc2627166ca81
Author: Alain FAGOT BEAREZ <ab...@for-scala.it>
Date:   2017-08-08T21:53:26Z

    use XDDF user model from XSSFChart

commit a0118d4839e16557501de4c0482d58b3ae9383bb
Author: Alain FAGOT BEAREZ <ab...@for-scala.it>
Date:   2017-08-10T21:40:46Z

    fix the examples to reflect the latest changes

commit 82e50f8c768ea1c66d027771992fe162c1fcad86
Author: Alain FAGOT BEAREZ <ab...@for-scala.it>
Date:   2017-08-12T22:43:38Z

    restore deleted API as @Deprecated

commit ad0e216f874178bbbebcf2f92694e293e1206425
Author: Alain FAGOT BEAREZ <ab...@for-scala.it>
Date:   2017-08-13T06:15:28Z

    undo some formatting changes to turn code review easier

commit ad6380356099858b3909a962d11501723a3485c0
Author: Alain FAGOT BEAREZ <ab...@for-scala.it>
Date:   2017-08-14T02:20:50Z

    restore the @Internal public methods leaking the CT* side of charts

commit 6aae7a367b739277ddf4ee24a909ec509786cb90
Author: Alain FAGOT BEAREZ <ab...@for-scala.it>
Date:   2017-08-15T18:58:13Z

    factor out common code between XSSFChart and XSLFChart

commit ea8c054d663bc116645c95e87a32c6c038f4930f
Author: Alain FAGOT BEAREZ <ab...@for-scala.it>
Date:   2017-08-16T02:06:38Z

    check all classes in XDDF are annotated as @Beta

commit 6befdb069eff1a88eca72f8bc0eef7e2a8072c3a
Author: Alain FAGOT BEAREZ <ab...@for-scala.it>
Date:   2017-08-21T07:46:02Z

    new checks are performed when creating an XSSFWorkbook with empty file

commit c2d91c58ecad193427672f3c1d1e2c1d34a23a63
Author: Alain FAGOT BEAREZ <ab...@for-scala.it>
Date:   2017-09-13T08:11:17Z

    cleaner handling of relations without relationships

commit f6ce4100d83bb4483ca24733ebb1b347f601be5a
Author: Alain FAGOT BEAREZ <ab...@for-scala.it>
Date:   2017-09-16T22:10:59Z

    Merge origin/trunk into xddf-usermodel

commit 7a5be1177006b9d10339c41348c684d361dd2fca
Author: Alain FAGOT BEAREZ <ab...@for-scala.it>
Date:   2017-09-16T22:36:30Z

    mark for removal in version 4.2 of elements deprecated by this branch

commit 3cfd976b3bb84647b8a84d6ba0b8320264f7b12b
Author: Alain FAGOT BEAREZ <ab...@for-scala.it>
Date:   2017-09-17T03:36:32Z

    mark for removal in version 4.2 of elements deprecated by this branch

commit f3170f2215c9801f019a5a672241ad5401cdd779
Author: Alain FAGOT BEAREZ <ab...@for-scala.it>
Date:   2017-09-17T04:04:04Z

    move all code down into chart package to make room for main and picture

commit ced81b979cf63ad80fc1c174af30066e63db40e1
Author: Alain FAGOT BEAREZ <ab...@for-scala.it>
Date:   2017-09-17T04:54:01Z

    fix whitespaces and typos

commit aca0622293755b59ecfdd4ca9ac9d5bb38b68d0e
Author: Alain FAGOT BEAREZ <ab...@for-scala.it>
Date:   2017-09-22T22:31:48Z

    Merge origin/trunk into xddf-usermodel

commit ce2347600eb9146e9e7351d30137d653d307c1bf
Author: Alain FAGOT BEAREZ <ab...@for-scala.it>
Date:   2017-09-22T22:39:49Z

    use try-with-resource to cleanly close output streams

commit e2b08f187a2018a9dd4e926ee8b332240c76fc65
Author: Alain FAGOT BEAREZ <ab...@for-scala.it>
Date:   2017-09-17T04:54:01Z

    introduce XDDFShapeProperties as user model API

commit 187e9ac5a39abbefd58dca1cd201e740a9dcf60f
Author: Alain FAGOT BEAREZ <ab...@for-scala.it>
Date:   2017-09-26T06:17:10Z

    add colors as user model

commit 681e813686332a4093223354ee6b68b1a3a6a973
Author: Alain FAGOT BEAREZ <ab...@for-scala.it>
Date:   2017-09-26T11:25:56Z

    dash stop list and gradient stop list

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[GitHub] poi pull request #72: Define XDDF user model for shape properties to be shar...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/poi/pull/72


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org