You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2021/11/12 11:46:07 UTC

[incubator-kyuubi] branch master updated: [KYUUBI #1368] Turn off debugging in dist scripts

This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new 9a55bf5  [KYUUBI #1368] Turn off debugging in dist scripts
9a55bf5 is described below

commit 9a55bf5e40fc1e57efbf63ca4138bbc39b9169a9
Author: sunfangbin <su...@cmss.chinamobile.com>
AuthorDate: Fri Nov 12 19:45:56 2021 +0800

    [KYUUBI #1368] Turn off debugging in dist scripts
    
    ### _Why are the changes needed?_
    `set -x` is currently used in dist scripts for debugging and the console looks a bit messy, it seems better to turn it off and users can enable it themselves if necessary.
    
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [x] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
    
    Closes #1368 from murong00/branch-1366.
    
    Closes #1368
    
    6373fe92 [sunfangbin] Turn off debugging in dist scripts
    
    Authored-by: sunfangbin <su...@cmss.chinamobile.com>
    Signed-off-by: Cheng Pan <ch...@apache.org>
---
 build/dist                        | 2 +-
 build/release/collect-licenses.sh | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/build/dist b/build/dist
index 8bb20e0..2e1e40c 100755
--- a/build/dist
+++ b/build/dist
@@ -26,7 +26,6 @@
 
 set -o pipefail
 set -e
-set -x
 
 KYUUBI_HOME="$(cd "`dirname "$0"`/.."; pwd)"
 DISTDIR="$KYUUBI_HOME/dist"
@@ -234,4 +233,5 @@ if [[ "$MAKE_TGZ" == "true" ]]; then
   cp -r "$DISTDIR" "$TARDIR"
   tar czf "$TARDIR_NAME.tgz" -C "$KYUUBI_HOME" "$TARDIR_NAME"
   rm -rf "$TARDIR"
+  echo "The Kyuubi tarball $TARDIR_NAME is successfully generated in $KYUUBI_HOME."
 fi
diff --git a/build/release/collect-licenses.sh b/build/release/collect-licenses.sh
index a4e8630..e88c284 100755
--- a/build/release/collect-licenses.sh
+++ b/build/release/collect-licenses.sh
@@ -26,7 +26,6 @@
 
 set -o pipefail
 set -e
-set -x
 
 SRC=${1:-.}
 DST=${2:-licenses-output}