You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "TezQA (Jira)" <ji...@apache.org> on 2020/04/22 17:07:00 UTC

[jira] [Commented] (TEZ-4154) tez-protobuf: a single module for handling protobuf dependency and its shading/relocating

    [ https://issues.apache.org/jira/browse/TEZ-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089861#comment-17089861 ] 

TezQA commented on TEZ-4154:
----------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 10m  3s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  2s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m  0s{color} | {color:green} The patch appears to include 34 new or modified test files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 30s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  6m  2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  6m 36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  6m 26s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  4m 45s{color} | {color:blue} Used deprecated FindBugs config; considering switching to SpotBugs. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m 41s{color} | {color:red} root in master has 2 extant findbugs warnings. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 47s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 27s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 27s{color} | {color:red} root in the patch failed. {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  1m 33s{color} | {color:orange} root: The patch generated 2 new + 1921 unchanged - 2 fixed = 1923 total (was 1923) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  0m 56s{color} | {color:orange} tez-dag: The patch generated 1 new + 1038 unchanged - 1 fixed = 1039 total (was 1039) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  0m 25s{color} | {color:orange} tez-tests: The patch generated 1 new + 47 unchanged - 1 fixed = 48 total (was 48) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m 18s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  6m 43s{color} | {color:green} the patch passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 21s{color} | {color:blue} tez-protobuf has no data from findbugs {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 33s{color} | {color:red} root in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 22s{color} | {color:green} tez-protobuf in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  2m  5s{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 58s{color} | {color:green} tez-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 38s{color} | {color:green} tez-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  4m  2s{color} | {color:red} tez-dag in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  1m  6s{color} | {color:red} tez-ext-service-tests in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 21s{color} | {color:green} tez-mapreduce in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  1m 46s{color} | {color:red} tez-aux-services in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 32s{color} | {color:green} tez-protobuf-history-plugin in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  3m 51s{color} | {color:red} tez-yarn-timeline-history-with-fs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 52s{color} | {color:green} tez-runtime-internals in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  5m  3s{color} | {color:green} tez-runtime-library in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 57m 58s{color} | {color:red} tez-tests in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  4m 50s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}175m 49s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | tez.dag.history.ats.acls.TestATSHistoryV15 |
|   | tez.auxservices.TestShuffleHandlerJobs |
|   | tez.dag.app.TestSpeculation |
|   | tez.dag.app.TestPreemption |
|   | tez.dag.app.TestMockDAGAppMaster |
|   | tez.tests.TestExternalTezServicesErrors |
|   | tez.tests.TestExtServicesWithLocalMode |
|   | tez.tests.TestExternalTezServices |
|   | tez.test.TestTezJobs |
|   | tez.test.TestAMRecovery |
|   | tez.test.TestLocalMode |
|   | tez.test.TestPipelinedShuffle |
|   | tez.test.TestExceptionPropagation |
|   | tez.test.TestRecovery |
|   | tez.test.TestSecureShuffle |
|   | tez.test.TestFaultTolerance |
|   | tez.test.TestTaskErrorsUsingLocalMode |
|   | tez.mapreduce.TestMRRJobs |
|   | tez.test.TestDAGRecovery |
|   | tez.test.TestDAGRecovery2 |
|   | tez.dag.app.TestSpeculation |
|   | tez.dag.app.TestPreemption |
|   | tez.dag.app.TestMockDAGAppMaster |
|   | tez.tests.TestExternalTezServicesErrors |
|   | tez.tests.TestExtServicesWithLocalMode |
|   | tez.tests.TestExternalTezServices |
|   | tez.auxservices.TestShuffleHandlerJobs |
|   | tez.dag.history.ats.acls.TestATSHistoryV15 |
|   | tez.test.TestTezJobs |
|   | tez.test.TestAMRecovery |
|   | tez.test.TestLocalMode |
|   | tez.test.TestPipelinedShuffle |
|   | tez.test.TestExceptionPropagation |
|   | tez.test.TestRecovery |
|   | tez.test.TestSecureShuffle |
|   | tez.test.TestFaultTolerance |
|   | tez.test.TestTaskErrorsUsingLocalMode |
|   | tez.mapreduce.TestMRRJobs |
|   | tez.test.TestDAGRecovery |
|   | tez.test.TestDAGRecovery2 |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/PreCommit-TEZ-Build/364/artifact/out/Dockerfile |
| JIRA Issue | TEZ-4154 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/13000850/TEZ-4154.01.patch |
| Optional Tests | dupname asflicense javac javadoc unit xml compile spotbugs findbugs checkstyle |
| uname | Linux a12f780e46b3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 3f8e753 |
| Default Java | 1.8.0_242 |
| findbugs | https://builds.apache.org/job/PreCommit-TEZ-Build/364/artifact/out/branch-findbugs-root-warnings.html |
| compile | https://builds.apache.org/job/PreCommit-TEZ-Build/364/artifact/out/patch-compile-root.txt |
| javac | https://builds.apache.org/job/PreCommit-TEZ-Build/364/artifact/out/patch-compile-root.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/364/artifact/out/diff-checkstyle-root.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/364/artifact/out/diff-checkstyle-tez-dag.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/364/artifact/out/diff-checkstyle-tez-tests.txt |
| findbugs | https://builds.apache.org/job/PreCommit-TEZ-Build/364/artifact/out/patch-findbugs-root.txt |
| unit | https://builds.apache.org/job/PreCommit-TEZ-Build/364/artifact/out/patch-unit-root.txt |
| unit | https://builds.apache.org/job/PreCommit-TEZ-Build/364/artifact/out/patch-unit-tez-dag.txt |
| unit | https://builds.apache.org/job/PreCommit-TEZ-Build/364/artifact/out/patch-unit-tez-ext-service-tests.txt |
| unit | https://builds.apache.org/job/PreCommit-TEZ-Build/364/artifact/out/patch-unit-tez-plugins_tez-aux-services.txt |
| unit | https://builds.apache.org/job/PreCommit-TEZ-Build/364/artifact/out/patch-unit-tez-plugins_tez-yarn-timeline-history-with-fs.txt |
| unit | https://builds.apache.org/job/PreCommit-TEZ-Build/364/artifact/out/patch-unit-tez-tests.txt |
|  Test Results | https://builds.apache.org/job/PreCommit-TEZ-Build/364/testReport/ |
| Max. process+thread count | 1441 (vs. ulimit of 5500) |
| modules | C: tez-protobuf . tez-api tez-common tez-dag tez-ext-service-tests tez-mapreduce tez-plugins/tez-aux-services tez-plugins/tez-protobuf-history-plugin tez-plugins/tez-yarn-timeline-history-with-fs tez-runtime-internals tez-runtime-library tez-tests U: . |
| Console output | https://builds.apache.org/job/PreCommit-TEZ-Build/364/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |


This message was automatically generated.



> tez-protobuf: a single module for handling protobuf dependency and its shading/relocating
> -----------------------------------------------------------------------------------------
>
>                 Key: TEZ-4154
>                 URL: https://issues.apache.org/jira/browse/TEZ-4154
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: László Bodor
>            Assignee: László Bodor
>            Priority: Major
>         Attachments: TEZ-4154.01.patch
>
>
> Similarly to what I've seen in TEZ-2164, I would like to create a module that is a single point of control of how tez handles protobuf dependency. In the near future, when tez will upgrade to hadoop 3.3, there will be a couple of things which should be taken care of (see TEZ-4152), e.g. upgrade to protobuf 3.x and handle the possible mess that can come from the fact that hadoop has relocated its protobuf.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)