You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/04 23:43:33 UTC
[GitHub] [kafka] bob-barrett opened a new pull request #10061: KAFKA-12193: Re-resolve IPs after a client disconnects (#9902)
bob-barrett opened a new pull request #10061:
URL: https://github.com/apache/kafka/pull/10061
This patch changes the NetworkClient behavior to resolve the target node's hostname after disconnecting from an established connection, rather than waiting until the previously-resolved addresses are exhausted. This is to handle the scenario when the node's IP addresses have changed during the lifetime of the connection, and means that the client does not have to try to connect to invalid IP addresses until it has tried each address.
Reviewers: Mickael Maison <mi...@gmail.com>, Satish Duggana <sa...@apache.org>, David Jacot <dj...@confluent.io>
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac merged pull request #10061: KAFKA-12193: Re-resolve IPs after a client disconnects
Posted by GitBox <gi...@apache.org>.
dajac merged pull request #10061:
URL: https://github.com/apache/kafka/pull/10061
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bob-barrett commented on pull request #10061: KAFKA-12193: Re-resolve IPs after a client disconnects
Posted by GitBox <gi...@apache.org>.
bob-barrett commented on pull request #10061:
URL: https://github.com/apache/kafka/pull/10061#issuecomment-773678032
@dajac This is the backport of https://github.com/apache/kafka/commit/131d4753cfed65ed6dee0a8c754765c97c3d513f. The conflicts were because the connection timeout settings added by [KIP-601](https://cwiki.apache.org/confluence/display/KAFKA/KIP-601%3A+Configurable+socket+connection+timeout+in+NetworkClient) aren't present in 2.6. This didn't change the behavior of this patch, but it did require a slight change in `NetworkClientTest#testFailedConnectionToFirstAddress` to simulate a failed connection, since sleeping for the connection timeout wasn't an option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #10061: KAFKA-12193: Re-resolve IPs after a client disconnects
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #10061:
URL: https://github.com/apache/kafka/pull/10061#issuecomment-774097673
@ableegoldman FYI - We have backported this fix to 2.6.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bob-barrett commented on pull request #10061: KAFKA-12193: Re-resolve IPs after a client disconnects
Posted by GitBox <gi...@apache.org>.
bob-barrett commented on pull request #10061:
URL: https://github.com/apache/kafka/pull/10061#issuecomment-773678032
@dajac This is the backport of https://github.com/apache/kafka/commit/131d4753cfed65ed6dee0a8c754765c97c3d513f. The conflicts were because the connection timeout settings added by [KIP-601](https://cwiki.apache.org/confluence/display/KAFKA/KIP-601%3A+Configurable+socket+connection+timeout+in+NetworkClient) aren't present in 2.6. This didn't change the behavior of this patch, but it did require a slight change in `NetworkClientTest#testFailedConnectionToFirstAddress` to simulate a failed connection, since sleeping for the connection timeout wasn't an option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org