You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2020/11/20 10:00:29 UTC
[GitHub] [cxf] jimma opened a new pull request #728: [CXF-8378]:Fix NoClassDefFoundError: org/apache/cxf/common/util/Refle…
jimma opened a new pull request #728:
URL: https://github.com/apache/cxf/pull/728
…ctionUtil
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] jimma commented on a change in pull request #728: [CXF-8378]:Fix NoClassDefFoundError: org/apache/cxf/common/util/Refle…
Posted by GitBox <gi...@apache.org>.
jimma commented on a change in pull request #728:
URL: https://github.com/apache/cxf/pull/728#discussion_r527630667
##########
File path: rt/transports/http/src/main/java/org/apache/cxf/transport/http/ReferencingAuthenticator.java
##########
@@ -122,15 +125,41 @@ PasswordAuthentication tryWith(Authenticator a) throws Exception {
if (a == null) {
return null;
}
- for (final Field f : ReflectionUtil.getDeclaredFields(Authenticator.class)) {
+ Field[] fileds = null;
Review comment:
Fixed. Thanks @andrei-ivanov .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] jimma merged pull request #728: [CXF-8378]:Fix NoClassDefFoundError: org/apache/cxf/common/util/Refle…
Posted by GitBox <gi...@apache.org>.
jimma merged pull request #728:
URL: https://github.com/apache/cxf/pull/728
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] jimma commented on pull request #728: [CXF-8378]:Fix NoClassDefFoundError: org/apache/cxf/common/util/Refle…
Posted by GitBox <gi...@apache.org>.
jimma commented on pull request #728:
URL: https://github.com/apache/cxf/pull/728#issuecomment-732022785
> LGTM - my only comment would be that you could check for the security manager in a static boolean and save repeated calls to `System.getSecurityManager() == null`. Thanks!
Thanks for review @andymc12 . Changed this as you suggested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] andrei-ivanov commented on a change in pull request #728: [CXF-8378]:Fix NoClassDefFoundError: org/apache/cxf/common/util/Refle…
Posted by GitBox <gi...@apache.org>.
andrei-ivanov commented on a change in pull request #728:
URL: https://github.com/apache/cxf/pull/728#discussion_r527594335
##########
File path: rt/transports/http/src/main/java/org/apache/cxf/transport/http/ReferencingAuthenticator.java
##########
@@ -122,15 +125,41 @@ PasswordAuthentication tryWith(Authenticator a) throws Exception {
if (a == null) {
return null;
}
- for (final Field f : ReflectionUtil.getDeclaredFields(Authenticator.class)) {
+ Field[] fileds = null;
Review comment:
typo: `fileds`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org