You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Aravindan Vijayan <av...@hortonworks.com> on 2017/02/01 19:54:33 UTC
Review Request 56186: AMBARI-19825 : Metrics data is not getting
collected for different services when AMS HTTPS is enabled
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56186/
-----------------------------------------------------------
Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-19825
https://issues.apache.org/jira/browse/AMBARI-19825
Repository: ambari
Description
-------
EXCEPTION TRACE
org.apache.hadoop.metrics2.impl.MetricsConfigException: Error creating plugin: org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink
at org.apache.hadoop.metrics2.impl.MetricsConfig.getPlugin(MetricsConfig.java:203)
at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.newSink(MetricsSystemImpl.java:529)
at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.configureSinks(MetricsSystemImpl.java:501)
Caused by: java.lang.IllegalArgumentException: no SSLSocketFactory specified
at javax.net.ssl.HttpsURLConnection.setSSLSocketFactory(HttpsURLConnection.java:357)
at org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.getSSLConnection(AbstractTimelineMetricsSink.java:284)
PROBLEM
AMS Sinks were trying to reach Metrics collector (running on HTTPS) to check liveness even before setting up truststore configs.
FIX
Made changes such that truststore is loaded before Sinks make any calls to metrics collector.
Diffs
-----
ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java c1b684b
ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java b2ca52e
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java 53250ee
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java 358b8fa
Diff: https://reviews.apache.org/r/56186/diff/
Testing
-------
Manually tested.
Relevant unit tests passed.
Thanks,
Aravindan Vijayan
Re: Review Request 56186: AMBARI-19825 : Metrics data is not getting
collected for different services when AMS HTTPS is enabled
Posted by Aravindan Vijayan <av...@hortonworks.com>.
> On Feb. 1, 2017, 9:40 p.m., Sid Wagle wrote:
> > What about Kafka sink?
Kafka does not initialize a seed collector host to start with. Hence the liveness check is never done during init.
- Aravindan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56186/#review163885
-----------------------------------------------------------
On Feb. 1, 2017, 7:54 p.m., Aravindan Vijayan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56186/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, 7:54 p.m.)
>
>
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-19825
> https://issues.apache.org/jira/browse/AMBARI-19825
>
>
> Repository: ambari
>
>
> Description
> -------
>
> EXCEPTION TRACE
>
> org.apache.hadoop.metrics2.impl.MetricsConfigException: Error creating plugin: org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink
> at org.apache.hadoop.metrics2.impl.MetricsConfig.getPlugin(MetricsConfig.java:203)
> at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.newSink(MetricsSystemImpl.java:529)
> at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.configureSinks(MetricsSystemImpl.java:501)
> Caused by: java.lang.IllegalArgumentException: no SSLSocketFactory specified
> at javax.net.ssl.HttpsURLConnection.setSSLSocketFactory(HttpsURLConnection.java:357)
> at org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.getSSLConnection(AbstractTimelineMetricsSink.java:284)
>
>
> PROBLEM
> AMS Sinks were trying to reach Metrics collector (running on HTTPS) to check liveness even before setting up truststore configs.
>
> FIX
> Made changes such that truststore is loaded before Sinks make any calls to metrics collector.
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java c1b684b
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java b2ca52e
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java 53250ee
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java 358b8fa
>
> Diff: https://reviews.apache.org/r/56186/diff/
>
>
> Testing
> -------
>
> Manually tested.
> Relevant unit tests passed.
>
>
> Thanks,
>
> Aravindan Vijayan
>
>
Re: Review Request 56186: AMBARI-19825 : Metrics data is not getting
collected for different services when AMS HTTPS is enabled
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56186/#review163885
-----------------------------------------------------------
Ship it!
What about Kafka sink?
- Sid Wagle
On Feb. 1, 2017, 7:54 p.m., Aravindan Vijayan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56186/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, 7:54 p.m.)
>
>
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-19825
> https://issues.apache.org/jira/browse/AMBARI-19825
>
>
> Repository: ambari
>
>
> Description
> -------
>
> EXCEPTION TRACE
>
> org.apache.hadoop.metrics2.impl.MetricsConfigException: Error creating plugin: org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink
> at org.apache.hadoop.metrics2.impl.MetricsConfig.getPlugin(MetricsConfig.java:203)
> at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.newSink(MetricsSystemImpl.java:529)
> at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.configureSinks(MetricsSystemImpl.java:501)
> Caused by: java.lang.IllegalArgumentException: no SSLSocketFactory specified
> at javax.net.ssl.HttpsURLConnection.setSSLSocketFactory(HttpsURLConnection.java:357)
> at org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.getSSLConnection(AbstractTimelineMetricsSink.java:284)
>
>
> PROBLEM
> AMS Sinks were trying to reach Metrics collector (running on HTTPS) to check liveness even before setting up truststore configs.
>
> FIX
> Made changes such that truststore is loaded before Sinks make any calls to metrics collector.
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java c1b684b
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java b2ca52e
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java 53250ee
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java 358b8fa
>
> Diff: https://reviews.apache.org/r/56186/diff/
>
>
> Testing
> -------
>
> Manually tested.
> Relevant unit tests passed.
>
>
> Thanks,
>
> Aravindan Vijayan
>
>