You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "valepakh (via GitHub)" <gi...@apache.org> on 2023/04/20 09:53:39 UTC
[GitHub] [ignite-3] valepakh opened a new pull request, #1961: IGNITE-19036 Add cli config remove command
valepakh opened a new pull request, #1961:
URL: https://github.com/apache/ignite-3/pull/1961
https://issues.apache.org/jira/browse/IGNITE-19036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] PakhomovAlexander merged pull request #1961: IGNITE-19036 Add cli config remove command
Posted by "PakhomovAlexander (via GitHub)" <gi...@apache.org>.
PakhomovAlexander merged PR #1961:
URL: https://github.com/apache/ignite-3/pull/1961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] PakhomovAlexander commented on a diff in pull request #1961: IGNITE-19036 Add cli config remove command
Posted by "PakhomovAlexander (via GitHub)" <gi...@apache.org>.
PakhomovAlexander commented on code in PR #1961:
URL: https://github.com/apache/ignite-3/pull/1961#discussion_r1173474804
##########
modules/cli/src/main/java/org/apache/ignite/internal/cli/call/cliconfig/CliConfigRemoveCallInput.java:
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.cli.call.cliconfig;
+
+import org.apache.ignite.internal.cli.core.call.CallInput;
+
+/** Input for {@link CliConfigRemoveCall}. */
+public class CliConfigRemoveCallInput implements CallInput {
+ private final String key;
+
+ private final String profileName;
+
+ private CliConfigRemoveCallInput(String key, String profileName) {
+ this.key = key;
+ this.profileName = profileName;
+ }
+
+ public static Builder builder() {
+ return new Builder();
+ }
+
+ public String getKey() {
Review Comment:
Could you please drop `get` prefix? As far as I know, we tent not to use them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] valepakh commented on a diff in pull request #1961: IGNITE-19036 Add cli config remove command
Posted by "valepakh (via GitHub)" <gi...@apache.org>.
valepakh commented on code in PR #1961:
URL: https://github.com/apache/ignite-3/pull/1961#discussion_r1173502679
##########
modules/cli/src/main/java/org/apache/ignite/internal/cli/call/cliconfig/CliConfigRemoveCallInput.java:
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.cli.call.cliconfig;
+
+import org.apache.ignite.internal.cli.core.call.CallInput;
+
+/** Input for {@link CliConfigRemoveCall}. */
+public class CliConfigRemoveCallInput implements CallInput {
+ private final String key;
+
+ private final String profileName;
+
+ private CliConfigRemoveCallInput(String key, String profileName) {
+ this.key = key;
+ this.profileName = profileName;
+ }
+
+ public static Builder builder() {
+ return new Builder();
+ }
+
+ public String getKey() {
Review Comment:
There are a lot of get prefixes even in the call inputs. Maybe we could do it separately?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org