You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2023/11/30 16:47:32 UTC
[PR] feat: Add `ArrowXXXCompare()` helpers for comparing schema and array objects [arrow-nanoarrow]
paleolimbot opened a new pull request, #329:
URL: https://github.com/apache/arrow-nanoarrow/pull/329
The main reason for this is to support integration testing; however, these are useful for testing and their absence has led to some creative/verbose testing patterns and/or inability to test on platforms where Arrow C++ doesn't build. I am hopeful to be able to implement something like `NANOARROW_COMPARE_TYPE_EQUAL` as well, but I think the "identical" level is all that is required to get integration testing going.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add `ArrowXXXCompare()` helpers for comparing schema and array objects [arrow-nanoarrow]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #329:
URL: https://github.com/apache/arrow-nanoarrow/pull/329#issuecomment-1834151912
## [Codecov](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/329?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`4744498`)](https://app.codecov.io/gh/apache/arrow-nanoarrow/commit/4744498daf166bc3ae8d34d157a2598002447d4e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 87.83% compared to head [(`8e6fec2`)](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/329?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 89.10%.
> Report is 1 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #329 +/- ##
==========================================
+ Coverage 87.83% 89.10% +1.27%
==========================================
Files 72 4 -68
Lines 11114 101 -11013
==========================================
- Hits 9762 90 -9672
+ Misses 1352 11 -1341
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/329?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add `ArrowXXXCompare()` helpers for comparing schema and array objects [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #329:
URL: https://github.com/apache/arrow-nanoarrow/pull/329#issuecomment-1856494789
Closing for now...comparison was implemented for integration tests using JSON.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add `ArrowXXXCompare()` helpers for comparing schema and array objects [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot closed pull request #329: feat: Add `ArrowXXXCompare()` helpers for comparing schema and array objects
URL: https://github.com/apache/arrow-nanoarrow/pull/329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org