You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/03/07 18:28:44 UTC

[kudu-CR] WIP [rpc] propagate RPC status for negotiation errors

Alexey Serbin has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6294

Change subject: WIP [rpc] propagate RPC status for negotiation errors
......................................................................

WIP [rpc] propagate RPC status for negotiation errors

To be able to distinguish between different cases of NotAuthorized
error for connection negotiation, it's necessary to pass in the
RPC status code sent by the remote peer.

This is in the context of the client retrying RPC calls in case of
FATAL_INVALID_AUTHENTICATION_TOKEN response from the server.

This changelist is a WIP because:
 * I don't think this is a good code yet
 * I suspect it can be done more elegant way instead of passing the raw
   RPC response as a parameter around.
 * I want to collect feedback and suggestions on how to do it right

Change-Id: Ib34a95d659a37c0967b5af7c8f96a344d0c42342
---
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/client_negotiation.h
M src/kudu/rpc/connection.cc
M src/kudu/rpc/connection.h
M src/kudu/rpc/negotiation.cc
M src/kudu/rpc/outbound_call.cc
M src/kudu/rpc/reactor.cc
M src/kudu/rpc/reactor.h
8 files changed, 73 insertions(+), 41 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/6294/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6294
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib34a95d659a37c0967b5af7c8f96a344d0c42342
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] WIP [rpc] propagate RPC status for negotiation errors

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has abandoned this change.

Change subject: WIP [rpc] propagate RPC status for negotiation errors
......................................................................


Abandoned

This change is now part of https://gerrit.cloudera.org/#/c/6648/

-- 
To view, visit http://gerrit.cloudera.org:8080/6294
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ib34a95d659a37c0967b5af7c8f96a344d0c42342
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>