[jira] [Commented] (KAFKA-5772) Improve Util classes

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301241#comment-16301241 ] 

ASF GitHub Bot commented on KAFKA-5772:
---------------------------------------

matzew commented on issue #3370: KAFKA-5772 Improve Util classes
URL: https://github.com/apache/kafka/pull/3370#issuecomment-353571386
 
 
   @ijuma should I close it or will it be merged ? :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Improve Util classes
> --------------------
>
>                 Key: KAFKA-5772
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5772
>             Project: Kafka
>          Issue Type: Improvement
>          Components: clients
>            Reporter: Matthias Weßendorf
>
> Utils with static methods should not be instantiated, hence we should improve them by marking the classes final and adding a private constructor as well.
> In addition this is consistent w/ a few of the existing Util classes, such as ByteUtils, see:
> https://github.com/apache/kafka/blob/d345d53e4e5e4f74707e2521aa635b93ba3f1e7b/clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java#L29-L31



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)