You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Oleg Kalnichevski <ol...@apache.org> on 2012/09/17 22:45:55 UTC

Re: svn commit: r1386795

On Mon, 2012-09-17 at 21:28 +0100, sebb wrote:
> On 17 September 2012 20:58,  <ol...@apache.org> wrote:
> > Author: olegk
> > Date: Mon Sep 17 19:58:17 2012
> > New Revision: 1386795
> >
> > URL: http://svn.apache.org/viewvc?rev=1386795&view=rev
> > Log:
> > HTTPCORE-312: LengthDelimitedEncoder incorrectly handles messages larger than 2GB
> >
> > Modified:
> >     httpcomponents/httpcore/branches/4.2.x/RELEASE_NOTES.txt
> >     httpcomponents/httpcore/branches/4.2.x/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/LengthDelimitedEncoder.java
> >
> > Modified: httpcomponents/httpcore/branches/4.2.x/RELEASE_NOTES.txt
> > URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/branches/4.2.x/RELEASE_NOTES.txt?rev=1386795&r1=1386794&r2=1386795&view=diff
> > ==============================================================================
> > --- httpcomponents/httpcore/branches/4.2.x/RELEASE_NOTES.txt (original)
> > +++ httpcomponents/httpcore/branches/4.2.x/RELEASE_NOTES.txt Mon Sep 17 19:58:17 2012
> > @@ -1,12 +1,18 @@
> >  Release 4.2.2
> >  -------------------
> >
> > -This is a maintenance release that fixes a number of bugs and regressions found since 4.2.1.
> > -Users of HttpCore 4.2 are encouraged to upgrade.
> > +This is a maintenance release that fixes a number of bugs and regressions found since 4.2.1
> > +including a major bug in NIO module causing incorrectly handling of outgoing Content-Length
> 
> s/in NIO/in the NIO/
> 
> s/incorrectly/incorrect/
> 

My bad. My English has its limits, especially if I forget to proofread.
Just fix and commit. I'll never complain ;-)

Oleg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Re: svn commit: r1386795

Posted by sebb <se...@gmail.com>.
On 17 September 2012 22:39, Oleg Kalnichevski <ol...@apache.org> wrote:
> On Mon, 2012-09-17 at 22:29 +0100, sebb wrote:
>> On 17 September 2012 21:45, Oleg Kalnichevski <ol...@apache.org> wrote:
>> > On Mon, 2012-09-17 at 21:28 +0100, sebb wrote:
>> >> On 17 September 2012 20:58,  <ol...@apache.org> wrote:
>> >> > Author: olegk
>> >> > Date: Mon Sep 17 19:58:17 2012
>> >> > New Revision: 1386795
>> >> >
>> >> > URL: http://svn.apache.org/viewvc?rev=1386795&view=rev
>> >> > Log:
>> >> > HTTPCORE-312: LengthDelimitedEncoder incorrectly handles messages larger than 2GB
>> >> >
>> >> > Modified:
>> >> >     httpcomponents/httpcore/branches/4.2.x/RELEASE_NOTES.txt
>> >> >     httpcomponents/httpcore/branches/4.2.x/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/LengthDelimitedEncoder.java
>> >> >
>> >> > Modified: httpcomponents/httpcore/branches/4.2.x/RELEASE_NOTES.txt
>> >> > URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/branches/4.2.x/RELEASE_NOTES.txt?rev=1386795&r1=1386794&r2=1386795&view=diff
>> >> > ==============================================================================
>> >> > --- httpcomponents/httpcore/branches/4.2.x/RELEASE_NOTES.txt (original)
>> >> > +++ httpcomponents/httpcore/branches/4.2.x/RELEASE_NOTES.txt Mon Sep 17 19:58:17 2012
>> >> > @@ -1,12 +1,18 @@
>> >> >  Release 4.2.2
>> >> >  -------------------
>> >> >
>> >> > -This is a maintenance release that fixes a number of bugs and regressions found since 4.2.1.
>> >> > -Users of HttpCore 4.2 are encouraged to upgrade.
>> >> > +This is a maintenance release that fixes a number of bugs and regressions found since 4.2.1
>> >> > +including a major bug in NIO module causing incorrectly handling of outgoing Content-Length
>> >>
>> >> s/in NIO/in the NIO/
>> >>
>> >> s/incorrectly/incorrect/
>> >>
>> >
>> > My bad. My English has its limits, especially if I forget to proofread.
>>
>> It's a lot easier proofreading someone else's prose ...
>>
>> > Just fix and commit. I'll never complain ;-)
>>
>> Sorry, that's me being lazy. I don't have a workspace for the files at
>> the moment.
>>
>
> That makes two of us ;-) Fixes committed. Please double-check.

Looks fine now, thanks.

> Oleg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Re: svn commit: r1386795

Posted by Oleg Kalnichevski <ol...@apache.org>.
On Mon, 2012-09-17 at 22:29 +0100, sebb wrote:
> On 17 September 2012 21:45, Oleg Kalnichevski <ol...@apache.org> wrote:
> > On Mon, 2012-09-17 at 21:28 +0100, sebb wrote:
> >> On 17 September 2012 20:58,  <ol...@apache.org> wrote:
> >> > Author: olegk
> >> > Date: Mon Sep 17 19:58:17 2012
> >> > New Revision: 1386795
> >> >
> >> > URL: http://svn.apache.org/viewvc?rev=1386795&view=rev
> >> > Log:
> >> > HTTPCORE-312: LengthDelimitedEncoder incorrectly handles messages larger than 2GB
> >> >
> >> > Modified:
> >> >     httpcomponents/httpcore/branches/4.2.x/RELEASE_NOTES.txt
> >> >     httpcomponents/httpcore/branches/4.2.x/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/LengthDelimitedEncoder.java
> >> >
> >> > Modified: httpcomponents/httpcore/branches/4.2.x/RELEASE_NOTES.txt
> >> > URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/branches/4.2.x/RELEASE_NOTES.txt?rev=1386795&r1=1386794&r2=1386795&view=diff
> >> > ==============================================================================
> >> > --- httpcomponents/httpcore/branches/4.2.x/RELEASE_NOTES.txt (original)
> >> > +++ httpcomponents/httpcore/branches/4.2.x/RELEASE_NOTES.txt Mon Sep 17 19:58:17 2012
> >> > @@ -1,12 +1,18 @@
> >> >  Release 4.2.2
> >> >  -------------------
> >> >
> >> > -This is a maintenance release that fixes a number of bugs and regressions found since 4.2.1.
> >> > -Users of HttpCore 4.2 are encouraged to upgrade.
> >> > +This is a maintenance release that fixes a number of bugs and regressions found since 4.2.1
> >> > +including a major bug in NIO module causing incorrectly handling of outgoing Content-Length
> >>
> >> s/in NIO/in the NIO/
> >>
> >> s/incorrectly/incorrect/
> >>
> >
> > My bad. My English has its limits, especially if I forget to proofread.
> 
> It's a lot easier proofreading someone else's prose ...
> 
> > Just fix and commit. I'll never complain ;-)
> 
> Sorry, that's me being lazy. I don't have a workspace for the files at
> the moment.
> 

That makes two of us ;-) Fixes committed. Please double-check.

Oleg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Re: svn commit: r1386795

Posted by sebb <se...@gmail.com>.
On 17 September 2012 21:45, Oleg Kalnichevski <ol...@apache.org> wrote:
> On Mon, 2012-09-17 at 21:28 +0100, sebb wrote:
>> On 17 September 2012 20:58,  <ol...@apache.org> wrote:
>> > Author: olegk
>> > Date: Mon Sep 17 19:58:17 2012
>> > New Revision: 1386795
>> >
>> > URL: http://svn.apache.org/viewvc?rev=1386795&view=rev
>> > Log:
>> > HTTPCORE-312: LengthDelimitedEncoder incorrectly handles messages larger than 2GB
>> >
>> > Modified:
>> >     httpcomponents/httpcore/branches/4.2.x/RELEASE_NOTES.txt
>> >     httpcomponents/httpcore/branches/4.2.x/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/LengthDelimitedEncoder.java
>> >
>> > Modified: httpcomponents/httpcore/branches/4.2.x/RELEASE_NOTES.txt
>> > URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/branches/4.2.x/RELEASE_NOTES.txt?rev=1386795&r1=1386794&r2=1386795&view=diff
>> > ==============================================================================
>> > --- httpcomponents/httpcore/branches/4.2.x/RELEASE_NOTES.txt (original)
>> > +++ httpcomponents/httpcore/branches/4.2.x/RELEASE_NOTES.txt Mon Sep 17 19:58:17 2012
>> > @@ -1,12 +1,18 @@
>> >  Release 4.2.2
>> >  -------------------
>> >
>> > -This is a maintenance release that fixes a number of bugs and regressions found since 4.2.1.
>> > -Users of HttpCore 4.2 are encouraged to upgrade.
>> > +This is a maintenance release that fixes a number of bugs and regressions found since 4.2.1
>> > +including a major bug in NIO module causing incorrectly handling of outgoing Content-Length
>>
>> s/in NIO/in the NIO/
>>
>> s/incorrectly/incorrect/
>>
>
> My bad. My English has its limits, especially if I forget to proofread.

It's a lot easier proofreading someone else's prose ...

> Just fix and commit. I'll never complain ;-)

Sorry, that's me being lazy. I don't have a workspace for the files at
the moment.

> Oleg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org