You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/21 08:54:33 UTC
[GitHub] [beam] alexeyinkin opened a new pull request, #21956: Do not re-create PlaygroundState (#21950)
alexeyinkin opened a new pull request, #21956:
URL: https://github.com/apache/beam/pull/21956
Fixes #21950
R: @damondouglas
We could not determine the reason why we were re-creating this state. It was this way since the inception of this file in October. Back then it did not matter because there were no async operations.
Classes like `PlaygroundState` should either be:
1. Mutable controllers, and persist throughout the life cycle of a parent widget, or
2. Immutable states emitted by some other business logic unit.
Currently, `PlaygroundState` is a mix of the two. Here we are making it (1).
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21956: Do not re-create PlaygroundState (#21950)
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21956:
URL: https://github.com/apache/beam/pull/21956#issuecomment-1161459250
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21956: Do not re-create PlaygroundState (#21950)
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21956:
URL: https://github.com/apache/beam/pull/21956#issuecomment-1161459237
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #21956: [Playground] Do not re-create PlaygroundState (#21950)
Posted by GitBox <gi...@apache.org>.
pabloem merged PR #21956:
URL: https://github.com/apache/beam/pull/21956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21956: Do not re-create PlaygroundState (#21950)
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21956:
URL: https://github.com/apache/beam/pull/21956#issuecomment-1161459239
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21956: Do not re-create PlaygroundState (#21950)
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21956:
URL: https://github.com/apache/beam/pull/21956#issuecomment-1161459241
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21956: Do not re-create PlaygroundState (#21950)
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21956:
URL: https://github.com/apache/beam/pull/21956#issuecomment-1161459244
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] alexeyinkin commented on pull request #21956: [Playground] Do not re-create PlaygroundState (#21950)
Posted by GitBox <gi...@apache.org>.
alexeyinkin commented on PR #21956:
URL: https://github.com/apache/beam/pull/21956#issuecomment-1161535335
R: @damondouglas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org