[GitHub] [ignite-3] lowka commented on a diff in pull request #1849: [IGNITE-18799] Sql. Custom types. Implement a basic set of test cases for a custom data type.

["lowka (via GitHub)" <gi...@apache.org>]

lowka commented on code in PR #1849:
URL: https://github.com/apache/ignite-3/pull/1849#discussion_r1171159282


##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/TypeCoercionTest.java:
##########
@@ -317,6 +319,82 @@ private static Stream<Arguments> commonTypeForBinaryComparison() {
         return arguments.stream();
     }
 
+    @ParameterizedTest
+    @MethodSource("widerTypeForCustomTypes")
+    public void testWiderTypeForCustomTypes(RelDataType type1, RelDataType type2, RelDataType expectedType) {
+        runTest("SELECT 1", (planner, ignore) -> {

Review Comment:
   Sure. But changes related to _wider type_ were committed by accident, and I am going to move them to a separate ticket + PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org