You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/11/25 20:36:14 UTC
[GitHub] [airflow] o-nikolas opened a new pull request, #27922: [AIP-51] Remove Executor coupling in ad_hoc_ti_run ui msg
o-nikolas opened a new pull request, #27922:
URL: https://github.com/apache/airflow/pull/27922
Changes:
1. Update the UI warning message to not be coupled to specific executors for `supports_ad_hoc_ti_run`
1. Also move the default value (`False`) for `supports_ad_hoc_ti_run` into the `BaseExecutor` class instead of in `views.py`. All Executors should have the default value of `False`, unless overridden intentionally to `True` (which `CeleryExecutor`, `KubernetesExecutor` and `CeleryKubernetesExecutor` already do)
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #27922: [AIP-51] Remove Executor coupling in ad_hoc_ti_run ui msg
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on PR #27922:
URL: https://github.com/apache/airflow/pull/27922#issuecomment-1328383106
Hi @o-nikolas , [the test failed again after I re-triggered it](https://github.com/apache/airflow/actions/runs/3551225297/jobs/5971279713). So it doesn't seem transient.
Please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #27922: [AIP-51] Remove Executor coupling in ad_hoc_ti_run ui msg
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on PR #27922:
URL: https://github.com/apache/airflow/pull/27922#issuecomment-1328094054
Restarted the failed check to see if it's transient failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #27922: [AIP-51] Remove Executor coupling in ad_hoc_ti_run ui msg
Posted by GitBox <gi...@apache.org>.
eladkal merged PR #27922:
URL: https://github.com/apache/airflow/pull/27922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on pull request #27922: [AIP-51] Remove Executor coupling in ad_hoc_ti_run ui msg
Posted by GitBox <gi...@apache.org>.
o-nikolas commented on PR #27922:
URL: https://github.com/apache/airflow/pull/27922#issuecomment-1329522363
> Hi @o-nikolas , [the test failed again after I re-triggered it](https://github.com/apache/airflow/actions/runs/3551225297/jobs/5971279713). So it doesn't seem transient.
>
> Please take a look
@XD-DENG
I've increasingly seen tests in PRs failing like this. The step looks like it's simply timing out at around 40+ minutes in the cases I've seen, and you get no logs.
I think there is a way to run the tests with debug logging enabled, but I can't find the magic to trigger that in our readmes. I know @potiuk has mentioned it before, can you weigh in Jarek?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org