You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/12/08 20:04:21 UTC
[GitHub] [kafka] dajac opened a new pull request, #12969: MINOR: Small refactor in ApiVersionManager
dajac opened a new pull request, #12969:
URL: https://github.com/apache/kafka/pull/12969
For KIP-848, I would like to check-in the new APIs but without exposing them while the KIP is in development. At first, my goal is to gate them by an internal configuration flag defined in KafkaConfig. Later one, this should be dynamic either based on MetadataVersion or another feature flag.
This patch is a small refactor in `ApiVersionManager` to allow filtering APIs. The basic idea is to filter them based on KafkaConfig [here](https://github.com/apache/kafka/compare/trunk...dajac:kafka:minor-refacor-apiversion-manager?expand=1#diff-b89d6d5e31fa117d2dfb7d242c5035c18556c783f58360ca3b42801100640090R44) so instead of letting the `ApiVersionManager` determine the available APIs based on the listener type, we give it the allowed set. This is definitely not the end state that I want but is a first step towards it. It will at least allow me to get this APIs checked in safely. We can come back to the dynamic part of it a bit later.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac closed pull request #12969: MINOR: Small refactor in ApiVersionManager
Posted by GitBox <gi...@apache.org>.
dajac closed pull request #12969: MINOR: Small refactor in ApiVersionManager
URL: https://github.com/apache/kafka/pull/12969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org