You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "caozhen1937 (via GitHub)" <gi...@apache.org> on 2025/07/07 10:34:50 UTC

Re: [PR] [iceberg] fix that dropPartition cannot sychronize the metadata to iceberg [paimon]

caozhen1937 commented on code in PR #5209:
URL: https://github.com/apache/paimon/pull/5209#discussion_r2189638826


##########
paimon-core/src/main/java/org/apache/paimon/AbstractFileStore.java:
##########
@@ -360,6 +360,8 @@ public TagDeletion newTagDeletion() {
 
     public abstract Comparator<InternalRow> newKeyComparator();
 
+    protected abstract List<CommitCallback> createCommitCallbacks(String commitUser);

Review Comment:
   > Can you move `AbstractFileStoreTable.createCommitCallbacks` to here and remove `newCommit(user, callbacks)` method?
   
   Hi @JingsongLi ,  how to use if user use oneself callbacks (now newCommit function can't transport callbacks)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org