You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "codenohup (via GitHub)" <gi...@apache.org> on 2024/10/15 05:02:31 UTC
[PR] [hotfix] throw transportable error when send addCredit rpc faild to avoid task get stuck [celeborn]
codenohup opened a new pull request, #2811:
URL: https://github.com/apache/celeborn/pull/2811
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
throw transportable error when send addCredit rpc faild to avoid task get stuck
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
by manual verification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] throw transportable error when send addCredit rpc faild to avoid task get stuck [celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on PR #2811:
URL: https://github.com/apache/celeborn/pull/2811#issuecomment-2413018753
Could you raise a jira ticket for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1652] Throw TransportableError for failure of sending addCredit to avoid flink task get stuck [celeborn]
Posted by "codenohup (via GitHub)" <gi...@apache.org>.
codenohup commented on code in PR #2811:
URL: https://github.com/apache/celeborn/pull/2811#discussion_r1800662349
##########
client-flink/common/src/main/java/org/apache/celeborn/plugin/flink/readclient/CelebornBufferStream.java:
##########
@@ -100,10 +100,11 @@ public void onSuccess(ByteBuffer response) {
@Override
public void onFailure(Throwable e) {
- logger.warn(
+ logger.error(
"Send PbReadAddCredit to {} failed, detail {}",
Review Comment:
> Add `streamId` in this log.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1652] Throw TransportableError for failure of sending PbReadAddCredit to avoid flink task get stuck [celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong closed pull request #2811: [CELEBORN-1652] Throw TransportableError for failure of sending PbReadAddCredit to avoid flink task get stuck
URL: https://github.com/apache/celeborn/pull/2811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1652] Throw transportable error for failure of sending addCredit to avoid flink task get stuck [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #2811:
URL: https://github.com/apache/celeborn/pull/2811#discussion_r1800609034
##########
client-flink/common/src/main/java/org/apache/celeborn/plugin/flink/readclient/CelebornBufferStream.java:
##########
@@ -100,10 +100,11 @@ public void onSuccess(ByteBuffer response) {
@Override
public void onFailure(Throwable e) {
- logger.warn(
+ logger.error(
"Send PbReadAddCredit to {} failed, detail {}",
Review Comment:
Add `streamId` in this log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1652] Throw TransportableError for failure of sending PbReadAddCredit to avoid flink task get stuck [celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on PR #2811:
URL: https://github.com/apache/celeborn/pull/2811#issuecomment-2414015192
Thanks. merged to main(v0.6.0) and branch-0.5(v0.5.2) and branch-0.4(v0.4.3)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1652] throw transportable error when failing to send addCredit rpc to avoid flink task get stuck [celeborn]
Posted by "codenohup (via GitHub)" <gi...@apache.org>.
codenohup commented on PR #2811:
URL: https://github.com/apache/celeborn/pull/2811#issuecomment-2413071902
> Could you raise a jira ticket for this?
@RexXiong Okay, I have created a [jira](https://issues.apache.org/jira/projects/CELEBORN/issues/CELEBORN-1652?filter=allopenissues) and renamed the commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] throw transportable error when send addCredit rpc faild to avoid task get stuck [celeborn]
Posted by "codenohup (via GitHub)" <gi...@apache.org>.
codenohup closed pull request #2811: [hotfix] throw transportable error when send addCredit rpc faild to avoid task get stuck
URL: https://github.com/apache/celeborn/pull/2811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org