You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Thomas Marshall <tw...@gmail.com> on 2012/06/20 19:58:06 UTC
Review Request: Renamed SimpleAllocator to DominantShareAllocator
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5448/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Description
-------
Renamed SimpleAllocator to DominantShareAllocator.
Diffs
-----
src/Makefile.am 8760f59
src/local/local.cpp d35639f
src/master/allocator_factory.cpp e4f4969
src/master/dominant_share_allocator.hpp PRE-CREATION
src/master/dominant_share_allocator.cpp PRE-CREATION
src/master/main.cpp bcbe35a
src/master/master.hpp 886f79c
src/master/simple_allocator.hpp 034b5d0
src/master/simple_allocator.cpp 1c54feb
src/tests/exception_tests.cpp de7fcf3
src/tests/fault_tolerance_tests.cpp b2529ca
src/tests/master_detector_tests.cpp 4cefbfa
src/tests/master_tests.cpp fcaf7dc
src/tests/resource_offers_tests.cpp c1f1760
src/tests/slave_tests.cpp 84e8e7d
Diff: https://reviews.apache.org/r/5448/diff/
Testing
-------
Thanks,
Thomas Marshall
Re: Review Request: Renamed SimpleAllocator to DominantShareAllocator
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5448/
-----------------------------------------------------------
(Updated June 26, 2012, 7:09 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
I created a Jira issue to track progress on the allocator work.
Description
-------
Renamed SimpleAllocator to DominantShareAllocator.
This addresses bug MESOS-222.
https://issues.apache.org/jira/browse/MESOS-222
Diffs
-----
src/Makefile.am 8760f59
src/local/local.cpp d35639f
src/master/allocator_factory.hpp 6387a5b
src/master/allocator_factory.cpp e4f4969
src/master/dominant_share_allocator.hpp PRE-CREATION
src/master/dominant_share_allocator.cpp PRE-CREATION
src/master/main.cpp bcbe35a
src/master/master.hpp 886f79c
src/master/master.cpp 89cdaf6
src/master/simple_allocator.hpp 034b5d0
src/master/simple_allocator.cpp 1c54feb
src/tests/exception_tests.cpp de7fcf3
src/tests/fault_tolerance_tests.cpp b2529ca
src/tests/master_detector_tests.cpp 4cefbfa
src/tests/master_tests.cpp fcaf7dc
src/tests/resource_offers_tests.cpp c1f1760
src/tests/slave_tests.cpp 84e8e7d
Diff: https://reviews.apache.org/r/5448/diff/
Testing
-------
Thanks,
Thomas Marshall
Re: Review Request: Renamed SimpleAllocator to DominantShareAllocator
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5448/
-----------------------------------------------------------
(Updated June 25, 2012, 6:17 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Removed allocator_factory.cpp and allocator_factory.hpp
Description
-------
Renamed SimpleAllocator to DominantShareAllocator.
Diffs (updated)
-----
src/Makefile.am 8760f59
src/local/local.cpp d35639f
src/master/allocator_factory.hpp 6387a5b
src/master/allocator_factory.cpp e4f4969
src/master/dominant_share_allocator.hpp PRE-CREATION
src/master/dominant_share_allocator.cpp PRE-CREATION
src/master/main.cpp bcbe35a
src/master/master.hpp 886f79c
src/master/master.cpp 89cdaf6
src/master/simple_allocator.hpp 034b5d0
src/master/simple_allocator.cpp 1c54feb
src/tests/exception_tests.cpp de7fcf3
src/tests/fault_tolerance_tests.cpp b2529ca
src/tests/master_detector_tests.cpp 4cefbfa
src/tests/master_tests.cpp fcaf7dc
src/tests/resource_offers_tests.cpp c1f1760
src/tests/slave_tests.cpp 84e8e7d
Diff: https://reviews.apache.org/r/5448/diff/
Testing
-------
Thanks,
Thomas Marshall
Re: Review Request: Renamed SimpleAllocator to DominantShareAllocator
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5448/#review8547
-----------------------------------------------------------
Ship it!
src/master/allocator_factory.cpp
<https://reviews.apache.org/r/5448/#comment18204>
We should probably ultimately eliminate this file.
- Benjamin Hindman
On June 22, 2012, 11:36 p.m., Thomas Marshall wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5448/
> -----------------------------------------------------------
>
> (Updated June 22, 2012, 11:36 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Description
> -------
>
> Renamed SimpleAllocator to DominantShareAllocator.
>
>
> Diffs
> -----
>
> src/Makefile.am 8760f59
> src/local/local.cpp d35639f
> src/master/allocator_factory.cpp e4f4969
> src/master/dominant_share_allocator.hpp PRE-CREATION
> src/master/dominant_share_allocator.cpp PRE-CREATION
> src/master/main.cpp bcbe35a
> src/master/master.hpp 886f79c
> src/master/simple_allocator.hpp 034b5d0
> src/master/simple_allocator.cpp 1c54feb
> src/tests/exception_tests.cpp de7fcf3
> src/tests/fault_tolerance_tests.cpp b2529ca
> src/tests/master_detector_tests.cpp 4cefbfa
> src/tests/master_tests.cpp fcaf7dc
> src/tests/resource_offers_tests.cpp c1f1760
> src/tests/slave_tests.cpp 84e8e7d
>
> Diff: https://reviews.apache.org/r/5448/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Marshall
>
>
Re: Review Request: Renamed SimpleAllocator to DominantShareAllocator
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5448/
-----------------------------------------------------------
(Updated June 22, 2012, 11:36 p.m.)
Review request for mesos and Benjamin Hindman.
Description
-------
Renamed SimpleAllocator to DominantShareAllocator.
Diffs
-----
src/Makefile.am 8760f59
src/local/local.cpp d35639f
src/master/allocator_factory.cpp e4f4969
src/master/dominant_share_allocator.hpp PRE-CREATION
src/master/dominant_share_allocator.cpp PRE-CREATION
src/master/main.cpp bcbe35a
src/master/master.hpp 886f79c
src/master/simple_allocator.hpp 034b5d0
src/master/simple_allocator.cpp 1c54feb
src/tests/exception_tests.cpp de7fcf3
src/tests/fault_tolerance_tests.cpp b2529ca
src/tests/master_detector_tests.cpp 4cefbfa
src/tests/master_tests.cpp fcaf7dc
src/tests/resource_offers_tests.cpp c1f1760
src/tests/slave_tests.cpp 84e8e7d
Diff: https://reviews.apache.org/r/5448/diff/
Testing
-------
Thanks,
Thomas Marshall
Re: Review Request: Renamed SimpleAllocator to DominantShareAllocator
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5448/
-----------------------------------------------------------
(Updated June 20, 2012, 9:28 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
A few minor fixes.
Description
-------
Renamed SimpleAllocator to DominantShareAllocator.
Diffs (updated)
-----
src/Makefile.am 8760f59
src/local/local.cpp d35639f
src/master/allocator_factory.cpp e4f4969
src/master/dominant_share_allocator.hpp PRE-CREATION
src/master/dominant_share_allocator.cpp PRE-CREATION
src/master/main.cpp bcbe35a
src/master/master.hpp 886f79c
src/master/simple_allocator.hpp 034b5d0
src/master/simple_allocator.cpp 1c54feb
src/tests/exception_tests.cpp de7fcf3
src/tests/fault_tolerance_tests.cpp b2529ca
src/tests/master_detector_tests.cpp 4cefbfa
src/tests/master_tests.cpp fcaf7dc
src/tests/resource_offers_tests.cpp c1f1760
src/tests/slave_tests.cpp 84e8e7d
Diff: https://reviews.apache.org/r/5448/diff/
Testing
-------
Thanks,
Thomas Marshall
Re: Review Request: Renamed SimpleAllocator to DominantShareAllocator
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5448/
-----------------------------------------------------------
(Updated June 20, 2012, 7:20 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
whitespace
Description
-------
Renamed SimpleAllocator to DominantShareAllocator.
Diffs (updated)
-----
src/Makefile.am 8760f59
src/local/local.cpp d35639f
src/master/allocator_factory.cpp e4f4969
src/master/dominant_share_allocator.hpp PRE-CREATION
src/master/dominant_share_allocator.cpp PRE-CREATION
src/master/main.cpp bcbe35a
src/master/master.hpp 886f79c
src/master/simple_allocator.hpp 034b5d0
src/master/simple_allocator.cpp 1c54feb
src/tests/exception_tests.cpp de7fcf3
src/tests/fault_tolerance_tests.cpp b2529ca
src/tests/master_detector_tests.cpp 4cefbfa
src/tests/master_tests.cpp fcaf7dc
src/tests/resource_offers_tests.cpp c1f1760
src/tests/slave_tests.cpp 84e8e7d
Diff: https://reviews.apache.org/r/5448/diff/
Testing
-------
Thanks,
Thomas Marshall
Re: Review Request: Renamed SimpleAllocator to DominantShareAllocator
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5448/
-----------------------------------------------------------
(Updated June 20, 2012, 5:58 p.m.)
Review request for mesos and Benjamin Hindman.
Description
-------
Renamed SimpleAllocator to DominantShareAllocator.
Diffs
-----
src/Makefile.am 8760f59
src/local/local.cpp d35639f
src/master/allocator_factory.cpp e4f4969
src/master/dominant_share_allocator.hpp PRE-CREATION
src/master/dominant_share_allocator.cpp PRE-CREATION
src/master/main.cpp bcbe35a
src/master/master.hpp 886f79c
src/master/simple_allocator.hpp 034b5d0
src/master/simple_allocator.cpp 1c54feb
src/tests/exception_tests.cpp de7fcf3
src/tests/fault_tolerance_tests.cpp b2529ca
src/tests/master_detector_tests.cpp 4cefbfa
src/tests/master_tests.cpp fcaf7dc
src/tests/resource_offers_tests.cpp c1f1760
src/tests/slave_tests.cpp 84e8e7d
Diff: https://reviews.apache.org/r/5448/diff/
Testing
-------
Thanks,
Thomas Marshall