[GitHub] edisongustavo commented on a change in pull request #14028: [WIP] Cmake blas

[GitBox <gi...@apache.org>]

edisongustavo commented on a change in pull request #14028: [WIP] Cmake blas
URL: https://github.com/apache/incubator-mxnet/pull/14028#discussion_r254195275
 
 

 ##########
 File path: cmake/Modules/FindOpenBLAS.cmake
 ##########
 @@ -14,78 +14,168 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+#
+# Finds the OpenBLAS library.
+#
+# The following variables are set after configuration is done:
+#
+# - OpenBLAS_FOUND
+# - OpenBLAS_INCLUDE_DIRS
+# - OpenBLAS_LIBRARIES
+#
+# This script will try to find the OpenBLAS library using the following mechanisms in this order:
+#
+# 1 - Use find_package(OpenBLAS) in Config mode. This is the recommended way to find dependencies
+#     with cmake.
+# 2 - Use pkg-config
+# 3 - Find the files manually
+#
+# At each step that was just described, in order to guarantee that the library was found correctly,
+# this script tries to compile this simple program:
+#
+# #include <cblas.h>
+# void main() { cblas_sasum(0, (float*)0, 0); }
+#
+# If this simple program can't be compiled with the found include directories provided by the step,
 
 Review comment:
   This looks better, I will change the text. Thanks for the suggestion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services