You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by franz1981 <gi...@git.apache.org> on 2018/12/06 15:05:28 UTC

[GitHub] activemq-artemis pull request #2434: ARTEMIS-1867 FQQN for producers

Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2434#discussion_r239486300
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/BindingsImpl.java ---
    @@ -53,7 +54,13 @@
     
        private final Map<SimpleString, Integer> routingNamePositions = new ConcurrentHashMap<>();
     
    -   private final Map<Long, Binding> bindingsMap = new ConcurrentHashMap<>();
    +   private final Map<Long, Binding> bindingsIdMap = new ConcurrentHashMap<>();
    --- End diff --
    
    Why not using a primitive version of this map? We have somewhere LongConcurrentHashMap (used into the journal too)


---