You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/21 15:38:00 UTC
[GitHub] [flink] AHeise opened a new pull request #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
AHeise opened a new pull request #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Made AsyncWaitOperator chainable to non-sources.
## Brief change log
- Adding HEAD_AFTER_LEGACY_SOURCE ChainingStrategy. Operators will be eagerly chained whenever possible, except after legacy sources.
- Made AsyncWaitOperator chainable to non-sources.
## Verifying this change
- Added AsyncWaitOperatorTest#testAsyncOperatorIsNotChainedToSources
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (**yes** / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#issuecomment-589720432
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b28a39aa682892a746495931949ab20dd1979c",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150047217",
"triggerID" : "61b28a39aa682892a746495931949ab20dd1979c",
"triggerType" : "PUSH"
}, {
"hash" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150094881",
"triggerID" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"triggerType" : "PUSH"
}, {
"hash" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5441",
"triggerID" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"triggerType" : "PUSH"
}, {
"hash" : "42f920ac137b14f43923fcee4677dc57c849fac2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150607307",
"triggerID" : "42f920ac137b14f43923fcee4677dc57c849fac2",
"triggerType" : "PUSH"
}, {
"hash" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150619538",
"triggerID" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"triggerType" : "PUSH"
}, {
"hash" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5611",
"triggerID" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 810b12ab01637f7d70d091922ba9cbf9bc45680e Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150619538) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5611)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#issuecomment-589720432
<!--
Meta data
Hash:61b28a39aa682892a746495931949ab20dd1979c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/150047217 TriggerType:PUSH TriggerID:61b28a39aa682892a746495931949ab20dd1979c
Hash:3d36bd3136fd8b56ee367ee29dc9c92beaf4542a Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/150094881 TriggerType:PUSH TriggerID:3d36bd3136fd8b56ee367ee29dc9c92beaf4542a
Hash:3d36bd3136fd8b56ee367ee29dc9c92beaf4542a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5441 TriggerType:PUSH TriggerID:3d36bd3136fd8b56ee367ee29dc9c92beaf4542a
-->
## CI report:
* 61b28a39aa682892a746495931949ab20dd1979c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150047217)
* 3d36bd3136fd8b56ee367ee29dc9c92beaf4542a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150094881) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5441)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on a change in pull request #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#discussion_r384319001
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/ChainingStrategy.java
##########
@@ -38,16 +38,46 @@
* <p>To optimize performance, it is generally a good practice to allow maximal
* chaining and increase operator parallelism.
*/
- ALWAYS,
+ ALWAYS {
+ @Override
+ public boolean canBeChainedTo(StreamOperatorFactory<?> headOperator) {
+ return true;
+ }
+ },
/**
* The operator will not be chained to the preceding or succeeding operators.
*/
- NEVER,
+ NEVER {
+ @Override
+ public boolean canBeChainedTo(StreamOperatorFactory<?> headOperator) {
+ return false;
+ }
+ },
/**
* The operator will not be chained to the predecessor, but successors may chain to this
* operator.
*/
- HEAD
+ HEAD {
+ @Override
+ public boolean canBeChainedTo(StreamOperatorFactory<?> headOperator) {
+ return false;
+ }
+ },
+
+ /**
+ * Operators will be eagerly chained whenever possible, except after legacy sources.
+ *
+ * <p>Operators that will not properly when processInput is called from another thread, must use this strategy
+ * instead of {@link #ALWAYS}.
+ */
+ HEAD_AFTER_LEGACY_SOURCE {
+ @Override
+ public boolean canBeChainedTo(StreamOperatorFactory<?> headOperator) {
+ return !headOperator.isStreamSource();
+ }
+ };
+
+ public abstract boolean canBeChainedTo(StreamOperatorFactory<?> headOperator);
Review comment:
Is yielding the root cause of not chainable to legacy sources?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#discussion_r383137052
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/ChainingStrategy.java
##########
@@ -38,16 +38,46 @@
* <p>To optimize performance, it is generally a good practice to allow maximal
* chaining and increase operator parallelism.
*/
- ALWAYS,
+ ALWAYS {
+ @Override
+ public boolean canBeChainedTo(StreamOperatorFactory<?> headOperator) {
Review comment:
`headOperator` is a misnomer, as it's not always "head". It's just previous/up stream operator. So at least `headOperator` -> `upStreamOperator` ?
However, also maybe optional/subjective, I would expect the call be here `head chained with next` instead of `next chained to head`:
```
headOperator.getChainingStrategy().canBeChainedWith/canBeChainedTo(outOperator)
```
as that's usually how lists/chains are being constructed/traversed - head to tail, so maybe:
```
canBeChainedWith(StreamOperatorFactory<?> downStreamOperator)
```
after all?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#issuecomment-589720432
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b28a39aa682892a746495931949ab20dd1979c",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150047217",
"triggerID" : "61b28a39aa682892a746495931949ab20dd1979c",
"triggerType" : "PUSH"
}, {
"hash" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150094881",
"triggerID" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"triggerType" : "PUSH"
}, {
"hash" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5441",
"triggerID" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"triggerType" : "PUSH"
}, {
"hash" : "42f920ac137b14f43923fcee4677dc57c849fac2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150607307",
"triggerID" : "42f920ac137b14f43923fcee4677dc57c849fac2",
"triggerType" : "PUSH"
}, {
"hash" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150619538",
"triggerID" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"triggerType" : "PUSH"
}, {
"hash" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5611",
"triggerID" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"triggerType" : "PUSH"
}, {
"hash" : "c8e0d15b1c909c2aa6a936f504d97ff0bd10303b",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5746",
"triggerID" : "c8e0d15b1c909c2aa6a936f504d97ff0bd10303b",
"triggerType" : "PUSH"
}, {
"hash" : "c8e0d15b1c909c2aa6a936f504d97ff0bd10303b",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151041801",
"triggerID" : "c8e0d15b1c909c2aa6a936f504d97ff0bd10303b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 810b12ab01637f7d70d091922ba9cbf9bc45680e Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150619538) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5611)
* c8e0d15b1c909c2aa6a936f504d97ff0bd10303b Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151041801) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5746)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#issuecomment-589720432
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b28a39aa682892a746495931949ab20dd1979c",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150047217",
"triggerID" : "61b28a39aa682892a746495931949ab20dd1979c",
"triggerType" : "PUSH"
}, {
"hash" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150094881",
"triggerID" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"triggerType" : "PUSH"
}, {
"hash" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5441",
"triggerID" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"triggerType" : "PUSH"
}, {
"hash" : "42f920ac137b14f43923fcee4677dc57c849fac2",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150607307",
"triggerID" : "42f920ac137b14f43923fcee4677dc57c849fac2",
"triggerType" : "PUSH"
}, {
"hash" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150619538",
"triggerID" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 42f920ac137b14f43923fcee4677dc57c849fac2 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150607307)
* 810b12ab01637f7d70d091922ba9cbf9bc45680e Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150619538)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on issue #11177: [FLINK-16219][runtime]
Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
AHeise commented on issue #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#issuecomment-591324986
Addressed all comments; let's wait for travis.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#issuecomment-589720432
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b28a39aa682892a746495931949ab20dd1979c",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150047217",
"triggerID" : "61b28a39aa682892a746495931949ab20dd1979c",
"triggerType" : "PUSH"
}, {
"hash" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150094881",
"triggerID" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"triggerType" : "PUSH"
}, {
"hash" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5441",
"triggerID" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"triggerType" : "PUSH"
}, {
"hash" : "42f920ac137b14f43923fcee4677dc57c849fac2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150607307",
"triggerID" : "42f920ac137b14f43923fcee4677dc57c849fac2",
"triggerType" : "PUSH"
}, {
"hash" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150619538",
"triggerID" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"triggerType" : "PUSH"
}, {
"hash" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5611",
"triggerID" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 810b12ab01637f7d70d091922ba9cbf9bc45680e Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150619538) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5611)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#discussion_r384347954
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
##########
@@ -602,9 +602,8 @@ public static boolean isChainable(StreamEdge edge, StreamGraph streamGraph) {
&& outOperator != null
&& headOperator != null
&& upStreamVertex.isSameSlotSharingGroup(downStreamVertex)
- && outOperator.getChainingStrategy() == ChainingStrategy.ALWAYS
- && (headOperator.getChainingStrategy() == ChainingStrategy.HEAD ||
- headOperator.getChainingStrategy() == ChainingStrategy.ALWAYS)
+ && outOperator.getChainingStrategy().canBeChainedTo(headOperator)
+ && headOperator.getChainingStrategy() != ChainingStrategy.NEVER
Review comment:
I would prefer to have one method to rule them all (to have one definite answer how to handle the chaining strategy), but as you prefer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#discussion_r383135416
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
##########
@@ -602,9 +602,8 @@ public static boolean isChainable(StreamEdge edge, StreamGraph streamGraph) {
&& outOperator != null
&& headOperator != null
&& upStreamVertex.isSameSlotSharingGroup(downStreamVertex)
- && outOperator.getChainingStrategy() == ChainingStrategy.ALWAYS
- && (headOperator.getChainingStrategy() == ChainingStrategy.HEAD ||
- headOperator.getChainingStrategy() == ChainingStrategy.ALWAYS)
+ && outOperator.getChainingStrategy().canBeChainedTo(headOperator)
+ && headOperator.getChainingStrategy() != ChainingStrategy.NEVER
Review comment:
Why can not we move `headOperator.getChainingStrategy() != ChainingStrategy.NEVER` into the `canBeChainedTo(headOperator)` call/check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on a change in pull request #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#discussion_r384319001
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/ChainingStrategy.java
##########
@@ -38,16 +38,46 @@
* <p>To optimize performance, it is generally a good practice to allow maximal
* chaining and increase operator parallelism.
*/
- ALWAYS,
+ ALWAYS {
+ @Override
+ public boolean canBeChainedTo(StreamOperatorFactory<?> headOperator) {
+ return true;
+ }
+ },
/**
* The operator will not be chained to the preceding or succeeding operators.
*/
- NEVER,
+ NEVER {
+ @Override
+ public boolean canBeChainedTo(StreamOperatorFactory<?> headOperator) {
+ return false;
+ }
+ },
/**
* The operator will not be chained to the predecessor, but successors may chain to this
* operator.
*/
- HEAD
+ HEAD {
+ @Override
+ public boolean canBeChainedTo(StreamOperatorFactory<?> headOperator) {
+ return false;
+ }
+ },
+
+ /**
+ * Operators will be eagerly chained whenever possible, except after legacy sources.
+ *
+ * <p>Operators that will not properly when processInput is called from another thread, must use this strategy
+ * instead of {@link #ALWAYS}.
+ */
+ HEAD_AFTER_LEGACY_SOURCE {
+ @Override
+ public boolean canBeChainedTo(StreamOperatorFactory<?> headOperator) {
+ return !headOperator.isStreamSource();
+ }
+ };
+
+ public abstract boolean canBeChainedTo(StreamOperatorFactory<?> headOperator);
Review comment:
Is yielding the root cause of not chainable to legacy sources? If so, then this is a valid way.
I'm concerned though that we also disallow chaining of operators that just need access to the mailboxExecutor for submit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#issuecomment-589720432
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b28a39aa682892a746495931949ab20dd1979c",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150047217",
"triggerID" : "61b28a39aa682892a746495931949ab20dd1979c",
"triggerType" : "PUSH"
}, {
"hash" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150094881",
"triggerID" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"triggerType" : "PUSH"
}, {
"hash" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5441",
"triggerID" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"triggerType" : "PUSH"
}, {
"hash" : "42f920ac137b14f43923fcee4677dc57c849fac2",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150607307",
"triggerID" : "42f920ac137b14f43923fcee4677dc57c849fac2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 42f920ac137b14f43923fcee4677dc57c849fac2 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150607307)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#discussion_r383141152
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/ChainingStrategy.java
##########
@@ -38,16 +38,46 @@
* <p>To optimize performance, it is generally a good practice to allow maximal
* chaining and increase operator parallelism.
*/
- ALWAYS,
+ ALWAYS {
+ @Override
+ public boolean canBeChainedTo(StreamOperatorFactory<?> headOperator) {
+ return true;
+ }
+ },
/**
* The operator will not be chained to the preceding or succeeding operators.
*/
- NEVER,
+ NEVER {
+ @Override
+ public boolean canBeChainedTo(StreamOperatorFactory<?> headOperator) {
+ return false;
+ }
+ },
/**
* The operator will not be chained to the predecessor, but successors may chain to this
* operator.
*/
- HEAD
+ HEAD {
+ @Override
+ public boolean canBeChainedTo(StreamOperatorFactory<?> headOperator) {
+ return false;
+ }
+ },
+
+ /**
+ * Operators will be eagerly chained whenever possible, except after legacy sources.
+ *
+ * <p>Operators that will not properly when processInput is called from another thread, must use this strategy
+ * instead of {@link #ALWAYS}.
+ */
+ HEAD_AFTER_LEGACY_SOURCE {
+ @Override
+ public boolean canBeChainedTo(StreamOperatorFactory<?> headOperator) {
+ return !headOperator.isStreamSource();
+ }
+ };
+
+ public abstract boolean canBeChainedTo(StreamOperatorFactory<?> headOperator);
Review comment:
Is it working properly? What if we have `StreamSource -> OP2 -> OP3 -> AsyncWaitOperator`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#discussion_r383142120
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperatorTest.java
##########
@@ -365,10 +365,10 @@ private void testProcessingTime(AsyncDataStream.OutputMode mode) throws Exceptio
}
/**
- * Test for the temporary fix to FLINK-13063.
+ * Tests FLINK-16219.
*/
@Test
- public void testAsyncOperatorIsNeverChained() {
+ public void testAsyncOperatorIsNotChainedToSources() {
StreamExecutionEnvironment chainEnv = StreamExecutionEnvironment.getExecutionEnvironment();
DataStream<Integer> input = chainEnv.fromElements(1);
Review comment:
add a simple mapping function?
```
input = chainEnv.fromElements(1).map(....);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on a change in pull request #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#discussion_r384318641
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/ChainingStrategy.java
##########
@@ -38,16 +38,46 @@
* <p>To optimize performance, it is generally a good practice to allow maximal
* chaining and increase operator parallelism.
*/
- ALWAYS,
+ ALWAYS {
+ @Override
+ public boolean canBeChainedTo(StreamOperatorFactory<?> headOperator) {
+ return true;
+ }
+ },
/**
* The operator will not be chained to the preceding or succeeding operators.
*/
- NEVER,
+ NEVER {
+ @Override
+ public boolean canBeChainedTo(StreamOperatorFactory<?> headOperator) {
+ return false;
+ }
+ },
/**
* The operator will not be chained to the predecessor, but successors may chain to this
* operator.
*/
- HEAD
+ HEAD {
+ @Override
+ public boolean canBeChainedTo(StreamOperatorFactory<?> headOperator) {
+ return false;
+ }
+ },
+
+ /**
+ * Operators will be eagerly chained whenever possible, except after legacy sources.
+ *
+ * <p>Operators that will not properly when processInput is called from another thread, must use this strategy
+ * instead of {@link #ALWAYS}.
+ */
+ HEAD_AFTER_LEGACY_SOURCE {
+ @Override
+ public boolean canBeChainedTo(StreamOperatorFactory<?> headOperator) {
+ return !headOperator.isStreamSource();
+ }
+ };
+
+ public abstract boolean canBeChainedTo(StreamOperatorFactory<?> headOperator);
Review comment:
It was not. Good catch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11177: [FLINK-16219][runtime]
Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#issuecomment-589707861
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 61b28a39aa682892a746495931949ab20dd1979c (Fri Feb 21 15:41:29 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#issuecomment-589720432
<!--
Meta data
Hash:61b28a39aa682892a746495931949ab20dd1979c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/150047217 TriggerType:PUSH TriggerID:61b28a39aa682892a746495931949ab20dd1979c
Hash:3d36bd3136fd8b56ee367ee29dc9c92beaf4542a Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/150094881 TriggerType:PUSH TriggerID:3d36bd3136fd8b56ee367ee29dc9c92beaf4542a
-->
## CI report:
* 61b28a39aa682892a746495931949ab20dd1979c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150047217)
* 3d36bd3136fd8b56ee367ee29dc9c92beaf4542a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150094881)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#issuecomment-589720432
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b28a39aa682892a746495931949ab20dd1979c",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150047217",
"triggerID" : "61b28a39aa682892a746495931949ab20dd1979c",
"triggerType" : "PUSH"
}, {
"hash" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150094881",
"triggerID" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"triggerType" : "PUSH"
}, {
"hash" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5441",
"triggerID" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"triggerType" : "PUSH"
}, {
"hash" : "42f920ac137b14f43923fcee4677dc57c849fac2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150607307",
"triggerID" : "42f920ac137b14f43923fcee4677dc57c849fac2",
"triggerType" : "PUSH"
}, {
"hash" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150619538",
"triggerID" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"triggerType" : "PUSH"
}, {
"hash" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5611",
"triggerID" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"triggerType" : "PUSH"
}, {
"hash" : "c8e0d15b1c909c2aa6a936f504d97ff0bd10303b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5746",
"triggerID" : "c8e0d15b1c909c2aa6a936f504d97ff0bd10303b",
"triggerType" : "PUSH"
}, {
"hash" : "c8e0d15b1c909c2aa6a936f504d97ff0bd10303b",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151041801",
"triggerID" : "c8e0d15b1c909c2aa6a936f504d97ff0bd10303b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c8e0d15b1c909c2aa6a936f504d97ff0bd10303b Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151041801) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5746)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#discussion_r383137978
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
##########
@@ -602,9 +602,8 @@ public static boolean isChainable(StreamEdge edge, StreamGraph streamGraph) {
&& outOperator != null
&& headOperator != null
&& upStreamVertex.isSameSlotSharingGroup(downStreamVertex)
- && outOperator.getChainingStrategy() == ChainingStrategy.ALWAYS
- && (headOperator.getChainingStrategy() == ChainingStrategy.HEAD ||
- headOperator.getChainingStrategy() == ChainingStrategy.ALWAYS)
+ && outOperator.getChainingStrategy().canBeChainedTo(headOperator)
+ && headOperator.getChainingStrategy() != ChainingStrategy.NEVER
Review comment:
Can we add a test coverage in `StreamingJobGraphGeneratorTest`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#discussion_r384348861
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
##########
@@ -542,14 +542,14 @@ private void connect(Integer headOfChain, StreamEdge edge) {
physicalEdgesInOrder.add(edge);
- Integer downStreamvertexID = edge.getTargetId();
+ Integer downstreamVertexID = edge.getTargetId();
Review comment:
nit: `downstream` -> `downStream` & `upstream` -> `upStream`. I quickly git grepped the code, and `downstream` is only used in text/docs. `downStream` is used in the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#discussion_r385604554
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
##########
@@ -587,30 +588,54 @@ private void connect(Integer headOfChain, StreamEdge edge) {
if (LOG.isDebugEnabled()) {
LOG.debug("CONNECTED: {} - {} -> {}", partitioner.getClass().getSimpleName(),
- headOfChain, downStreamvertexID);
+ headOfChain, downStreamVertexID);
}
}
public static boolean isChainable(StreamEdge edge, StreamGraph streamGraph) {
StreamNode upStreamVertex = streamGraph.getSourceVertex(edge);
StreamNode downStreamVertex = streamGraph.getTargetVertex(edge);
- StreamOperatorFactory<?> headOperator = upStreamVertex.getOperatorFactory();
- StreamOperatorFactory<?> outOperator = downStreamVertex.getOperatorFactory();
-
return downStreamVertex.getInEdges().size() == 1
- && outOperator != null
- && headOperator != null
&& upStreamVertex.isSameSlotSharingGroup(downStreamVertex)
- && outOperator.getChainingStrategy() == ChainingStrategy.ALWAYS
- && (headOperator.getChainingStrategy() == ChainingStrategy.HEAD ||
- headOperator.getChainingStrategy() == ChainingStrategy.ALWAYS)
+ && areOperatorsChainable(upStreamVertex, downStreamVertex, streamGraph)
&& (edge.getPartitioner() instanceof ForwardPartitioner)
&& edge.getShuffleMode() != ShuffleMode.BATCH
&& upStreamVertex.getParallelism() == downStreamVertex.getParallelism()
&& streamGraph.isChainingEnabled();
}
+ private static boolean areOperatorsChainable(
Review comment:
Can we unit test this method assuming that `StreamNode` and `StreamGraph` are easy to construct/mock?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#discussion_r383140720
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/ChainingStrategy.java
##########
@@ -38,16 +38,46 @@
* <p>To optimize performance, it is generally a good practice to allow maximal
* chaining and increase operator parallelism.
*/
- ALWAYS,
+ ALWAYS {
+ @Override
+ public boolean canBeChainedTo(StreamOperatorFactory<?> headOperator) {
+ return true;
+ }
+ },
/**
* The operator will not be chained to the preceding or succeeding operators.
*/
- NEVER,
+ NEVER {
+ @Override
+ public boolean canBeChainedTo(StreamOperatorFactory<?> headOperator) {
+ return false;
+ }
+ },
/**
* The operator will not be chained to the predecessor, but successors may chain to this
* operator.
*/
- HEAD
+ HEAD {
+ @Override
+ public boolean canBeChainedTo(StreamOperatorFactory<?> headOperator) {
+ return false;
+ }
+ },
+
+ /**
+ * Operators will be eagerly chained whenever possible, except after legacy sources.
+ *
+ * <p>Operators that will not properly when processInput is called from another thread, must use this strategy
+ * instead of {@link #ALWAYS}.
+ */
+ HEAD_AFTER_LEGACY_SOURCE {
+ @Override
+ public boolean canBeChainedTo(StreamOperatorFactory<?> headOperator) {
+ return !headOperator.isStreamSource();
+ }
+ };
+
+ public abstract boolean canBeChainedTo(StreamOperatorFactory<?> headOperator);
Review comment:
Do we need this enum? Can not we replace `HEAD_AFTER_LEGACY_SOURCE` with a check if that we are in a legacy source task and the `downStreamOpeartor instanceof YieldingOperatorFactory`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#issuecomment-589720432
<!--
Meta data
Hash:61b28a39aa682892a746495931949ab20dd1979c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/150047217 TriggerType:PUSH TriggerID:61b28a39aa682892a746495931949ab20dd1979c
-->
## CI report:
* 61b28a39aa682892a746495931949ab20dd1979c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150047217)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski merged pull request #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on issue #11177: [FLINK-16219][runtime]
Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
AHeise commented on issue #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#issuecomment-591401288
@pnowojski green
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#issuecomment-589707861
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c8e0d15b1c909c2aa6a936f504d97ff0bd10303b (Fri Feb 28 21:49:58 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#issuecomment-589720432
<!--
Meta data
Hash:61b28a39aa682892a746495931949ab20dd1979c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/150047217 TriggerType:PUSH TriggerID:61b28a39aa682892a746495931949ab20dd1979c
Hash:3d36bd3136fd8b56ee367ee29dc9c92beaf4542a Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:3d36bd3136fd8b56ee367ee29dc9c92beaf4542a
-->
## CI report:
* 61b28a39aa682892a746495931949ab20dd1979c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150047217)
* 3d36bd3136fd8b56ee367ee29dc9c92beaf4542a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#issuecomment-589720432
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b28a39aa682892a746495931949ab20dd1979c",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150047217",
"triggerID" : "61b28a39aa682892a746495931949ab20dd1979c",
"triggerType" : "PUSH"
}, {
"hash" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150094881",
"triggerID" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"triggerType" : "PUSH"
}, {
"hash" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5441",
"triggerID" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3d36bd3136fd8b56ee367ee29dc9c92beaf4542a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150094881) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5441)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#issuecomment-589720432
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b28a39aa682892a746495931949ab20dd1979c",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150047217",
"triggerID" : "61b28a39aa682892a746495931949ab20dd1979c",
"triggerType" : "PUSH"
}, {
"hash" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150094881",
"triggerID" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"triggerType" : "PUSH"
}, {
"hash" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5441",
"triggerID" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"triggerType" : "PUSH"
}, {
"hash" : "42f920ac137b14f43923fcee4677dc57c849fac2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "42f920ac137b14f43923fcee4677dc57c849fac2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3d36bd3136fd8b56ee367ee29dc9c92beaf4542a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150094881) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5441)
* 42f920ac137b14f43923fcee4677dc57c849fac2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#issuecomment-589720432
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b28a39aa682892a746495931949ab20dd1979c",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150047217",
"triggerID" : "61b28a39aa682892a746495931949ab20dd1979c",
"triggerType" : "PUSH"
}, {
"hash" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150094881",
"triggerID" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"triggerType" : "PUSH"
}, {
"hash" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5441",
"triggerID" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"triggerType" : "PUSH"
}, {
"hash" : "42f920ac137b14f43923fcee4677dc57c849fac2",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150607307",
"triggerID" : "42f920ac137b14f43923fcee4677dc57c849fac2",
"triggerType" : "PUSH"
}, {
"hash" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 42f920ac137b14f43923fcee4677dc57c849fac2 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150607307)
* 810b12ab01637f7d70d091922ba9cbf9bc45680e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#issuecomment-589720432
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b28a39aa682892a746495931949ab20dd1979c",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150047217",
"triggerID" : "61b28a39aa682892a746495931949ab20dd1979c",
"triggerType" : "PUSH"
}, {
"hash" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150094881",
"triggerID" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"triggerType" : "PUSH"
}, {
"hash" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5441",
"triggerID" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"triggerType" : "PUSH"
}, {
"hash" : "42f920ac137b14f43923fcee4677dc57c849fac2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150607307",
"triggerID" : "42f920ac137b14f43923fcee4677dc57c849fac2",
"triggerType" : "PUSH"
}, {
"hash" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150619538",
"triggerID" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"triggerType" : "PUSH"
}, {
"hash" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5611",
"triggerID" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"triggerType" : "PUSH"
}, {
"hash" : "c8e0d15b1c909c2aa6a936f504d97ff0bd10303b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c8e0d15b1c909c2aa6a936f504d97ff0bd10303b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 810b12ab01637f7d70d091922ba9cbf9bc45680e Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150619538) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5611)
* c8e0d15b1c909c2aa6a936f504d97ff0bd10303b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11177: [FLINK-16219][runtime]
Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#issuecomment-589720432
<!--
Meta data
Hash:61b28a39aa682892a746495931949ab20dd1979c Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:61b28a39aa682892a746495931949ab20dd1979c
-->
## CI report:
* 61b28a39aa682892a746495931949ab20dd1979c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#issuecomment-589720432
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b28a39aa682892a746495931949ab20dd1979c",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150047217",
"triggerID" : "61b28a39aa682892a746495931949ab20dd1979c",
"triggerType" : "PUSH"
}, {
"hash" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150094881",
"triggerID" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"triggerType" : "PUSH"
}, {
"hash" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5441",
"triggerID" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 61b28a39aa682892a746495931949ab20dd1979c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150047217)
* 3d36bd3136fd8b56ee367ee29dc9c92beaf4542a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150094881) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5441)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#issuecomment-589720432
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b28a39aa682892a746495931949ab20dd1979c",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150047217",
"triggerID" : "61b28a39aa682892a746495931949ab20dd1979c",
"triggerType" : "PUSH"
}, {
"hash" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150094881",
"triggerID" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"triggerType" : "PUSH"
}, {
"hash" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5441",
"triggerID" : "3d36bd3136fd8b56ee367ee29dc9c92beaf4542a",
"triggerType" : "PUSH"
}, {
"hash" : "42f920ac137b14f43923fcee4677dc57c849fac2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150607307",
"triggerID" : "42f920ac137b14f43923fcee4677dc57c849fac2",
"triggerType" : "PUSH"
}, {
"hash" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150619538",
"triggerID" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"triggerType" : "PUSH"
}, {
"hash" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5611",
"triggerID" : "810b12ab01637f7d70d091922ba9cbf9bc45680e",
"triggerType" : "PUSH"
}, {
"hash" : "c8e0d15b1c909c2aa6a936f504d97ff0bd10303b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5746",
"triggerID" : "c8e0d15b1c909c2aa6a936f504d97ff0bd10303b",
"triggerType" : "PUSH"
}, {
"hash" : "c8e0d15b1c909c2aa6a936f504d97ff0bd10303b",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151041801",
"triggerID" : "c8e0d15b1c909c2aa6a936f504d97ff0bd10303b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c8e0d15b1c909c2aa6a936f504d97ff0bd10303b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/151041801) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5746)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#issuecomment-589720432
<!--
Meta data
Hash:61b28a39aa682892a746495931949ab20dd1979c Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/150047217 TriggerType:PUSH TriggerID:61b28a39aa682892a746495931949ab20dd1979c
-->
## CI report:
* 61b28a39aa682892a746495931949ab20dd1979c Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150047217)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#issuecomment-589720432
<!--
Meta data
Hash:61b28a39aa682892a746495931949ab20dd1979c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/150047217 TriggerType:PUSH TriggerID:61b28a39aa682892a746495931949ab20dd1979c
Hash:3d36bd3136fd8b56ee367ee29dc9c92beaf4542a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/150094881 TriggerType:PUSH TriggerID:3d36bd3136fd8b56ee367ee29dc9c92beaf4542a
Hash:3d36bd3136fd8b56ee367ee29dc9c92beaf4542a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5441 TriggerType:PUSH TriggerID:3d36bd3136fd8b56ee367ee29dc9c92beaf4542a
-->
## CI report:
* 61b28a39aa682892a746495931949ab20dd1979c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150047217)
* 3d36bd3136fd8b56ee367ee29dc9c92beaf4542a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150094881) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5441)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on a change in pull request #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#discussion_r384320045
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
##########
@@ -602,9 +602,8 @@ public static boolean isChainable(StreamEdge edge, StreamGraph streamGraph) {
&& outOperator != null
&& headOperator != null
&& upStreamVertex.isSameSlotSharingGroup(downStreamVertex)
- && outOperator.getChainingStrategy() == ChainingStrategy.ALWAYS
- && (headOperator.getChainingStrategy() == ChainingStrategy.HEAD ||
- headOperator.getChainingStrategy() == ChainingStrategy.ALWAYS)
+ && outOperator.getChainingStrategy().canBeChainedTo(headOperator)
+ && headOperator.getChainingStrategy() != ChainingStrategy.NEVER
Review comment:
A different question imho. First, is upstream supporting chaining at all? Second, is this specific downstream chainable to the upstream.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on a change in pull request #11177:
[FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11177: [FLINK-16219][runtime] Made AsyncWaitOperator chainable to non-sources.
URL: https://github.com/apache/flink/pull/11177#discussion_r384319679
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/ChainingStrategy.java
##########
@@ -38,16 +38,46 @@
* <p>To optimize performance, it is generally a good practice to allow maximal
* chaining and increase operator parallelism.
*/
- ALWAYS,
+ ALWAYS {
+ @Override
+ public boolean canBeChainedTo(StreamOperatorFactory<?> headOperator) {
Review comment:
Renamed vars in a separate hotfix.
For the remainder naming, I think it's the other way around. If I construct head to tail, I'd ask can this node by chained to the head?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services