You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by pv...@apache.org on 2017/08/10 08:55:20 UTC
nifi git commit: NIFI-1027 - Treat label and node of a provenance
graph event as one unit
Repository: nifi
Updated Branches:
refs/heads/master 5150dff70 -> 505e93065
NIFI-1027 - Treat label and node of a provenance graph event as one unit
The JIRA issue asks for treating both node and its label as one unit.
Described cursor issues seems to be fixed already.
However, there is an annoying dead space between a node and label
preventing displaying context menu, etc. Due to SVG group's nature
there has been added an opaque joint to remove the dead space.
Signed-off-by: Pierre Villard <pi...@gmail.com>
This closes #2059.
Project: http://git-wip-us.apache.org/repos/asf/nifi/repo
Commit: http://git-wip-us.apache.org/repos/asf/nifi/commit/505e9306
Tree: http://git-wip-us.apache.org/repos/asf/nifi/tree/505e9306
Diff: http://git-wip-us.apache.org/repos/asf/nifi/diff/505e9306
Branch: refs/heads/master
Commit: 505e93065ec98a45d75f0308255d4b3f42ba4389
Parents: 5150dff
Author: yuri1969 <19...@gmail.com>
Authored: Sat Aug 5 16:57:48 2017 +0200
Committer: Pierre Villard <pi...@gmail.com>
Committed: Thu Aug 10 10:54:47 2017 +0200
----------------------------------------------------------------------
.../webapp/js/nf/provenance/nf-provenance-lineage.js | 14 ++++++++++++++
1 file changed, 14 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/nifi/blob/505e9306/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/provenance/nf-provenance-lineage.js
----------------------------------------------------------------------
diff --git a/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/provenance/nf-provenance-lineage.js b/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/provenance/nf-provenance-lineage.js
index c3157f7..6295c0b 100644
--- a/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/provenance/nf-provenance-lineage.js
+++ b/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/provenance/nf-provenance-lineage.js
@@ -1019,6 +1019,20 @@
events
.classed('event', true)
+ // join node to its label
+ .append('rect')
+ .attr({
+ 'x': 0,
+ 'y': -8,
+ 'height': 16,
+ 'width': 14,
+ 'opacity': 0,
+ 'id': function (d) {
+ return 'event-filler-' + d.id;
+ }
+ });
+
+ events
.append('circle')
.classed('selected', function (d) {
return d.id === eventId;