You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "adamsaghy (via GitHub)" <gi...@apache.org> on 2024/05/03 07:30:15 UTC
Re: [PR] FINERACT-1971: Down payment (auto) transaction using installment mult… [fineract]
adamsaghy commented on code in PR #3873:
URL: https://github.com/apache/fineract/pull/3873#discussion_r1588837433
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/LoanInstallmentMultiplesOfTest.java:
##########
@@ -141,21 +141,21 @@ public void test_LoanRepaymentScheduleIsEquallyDistributed_WhenInterestIsPresent
// Verify Repayment Schedule
verifyRepaymentSchedule(loanId, //
- installment(1250.0, null, "01 January 2023"), //
- installment(417.5, 12.5, 430.0, false, "01 February 2023"), //
- installment(417.5, 12.5, 430.0, false, "01 March 2023"), //
- installment(415.0, 12.5, 427.5, false, "01 April 2023") //
+ installment(0, null, "01 January 2023"), //
+ installment(416.5, 12.5, 429.0, false, "01 February 2023"), //
+ installment(416.5, 12.5, 429.0, false, "01 March 2023"), //
+ installment(417.0, 12.5, 429.5, false, "01 April 2023") //
);
// disburse Loan
disburseLoan(loanId, BigDecimal.valueOf(1250.0), "01 January 2023");
// Verify Repayment Schedule
verifyRepaymentSchedule(loanId, //
- installment(1250.0, null, "01 January 2023"), //
- installment(417.5, 12.5, 430.0, false, "01 February 2023"), //
- installment(417.5, 12.5, 430.0, false, "01 March 2023"), //
- installment(415.0, 12.5, 427.5, false, "01 April 2023") //
+ installment(0, null, "01 January 2023"), //
Review Comment:
This will fail! the disbursement installment cannot be 0!
Please make sure it contains the correct amounts! (1250 in this example)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org