Github fork pull request branch name convention

[Simon Arame <sa...@gmail.com>]

Hi,

I would like to submit a pull request or merge request for tomcat. We have
created a fork on Github. What is the standard way to proceed. Should I
commit to my copy of the "main" branch or create a special branch with a
particular name ?

Simon

Re: Github fork pull request branch name convention

[Christopher Schultz <ch...@christopherschultz.net>]

Simon,

On 7/27/25 1:46 PM, Simon Arame wrote:
> I would like to submit a pull request or merge request for tomcat. We have
> created a fork on Github. What is the standard way to proceed. Should I
> commit to my copy of the "main" branch or create a special branch with a
> particular name ?

I have found that every time I commit to a fork's main branch, I regret 
it and wish I had done a separate branch just for the PR.

I would recommend a branch, but you can do whatever you want; the PR 
doesn't care which branch you use (including main).

-chris


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: Github fork pull request branch name convention

[Mark Thomas <ma...@apache.org>]

27 Jul 2025 18:46:37 Simon Arame <sa...@gmail.com>:

> Hi,
>
> I would like to submit a pull request or merge request for tomcat. We 
> have
> created a fork on Github. What is the standard way to proceed. Should I
> commit to my copy of the "main" branch or create a special branch with 
> a
> particular name ?
>
> Simon

You don't have write access to the Tomcat repo.

Create a PR against whichever branch you worked on in your fork.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org