You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by ha...@apache.org on 2021/12/20 15:25:08 UTC

[incubator-hop] branch master updated: HOP-3546: change note and wording on textfile input samples

This is an automated email from the ASF dual-hosted git repository.

hansva pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-hop.git


The following commit(s) were added to refs/heads/master by this push:
     new c73f903  HOP-3546: change note and wording on textfile input samples
     new 8435c9c  Merge pull request #1234 from hansva/master
c73f903 is described below

commit c73f903ea458c3e7d999ecf0528c9bcf2753e9df
Author: Hans Van Akelyen <ha...@gmail.com>
AuthorDate: Mon Dec 20 16:11:55 2021 +0100

    HOP-3546: change note and wording on textfile input samples
    
    
    HOP-3546
---
 .../src/main/samples/transforms/csvinput-basic.hpl        |  8 ++++----
 .../src/main/samples/transforms/csvinput-huge-file.hpl    | 15 ++++++++-------
 .../src/main/samples/transforms/textfileinput-basic.hpl   | 12 ++++++------
 3 files changed, 18 insertions(+), 17 deletions(-)

diff --git a/plugins/transforms/textfile/src/main/samples/transforms/csvinput-basic.hpl b/plugins/transforms/textfile/src/main/samples/transforms/csvinput-basic.hpl
index 6dcdcea..062f818 100644
--- a/plugins/transforms/textfile/src/main/samples/transforms/csvinput-basic.hpl
+++ b/plugins/transforms/textfile/src/main/samples/transforms/csvinput-basic.hpl
@@ -40,13 +40,13 @@ limitations under the License.
   <notepads>
     <notepad>
       <note>Reads a simple csv file and output the results. 
-This sample uses a file that is generated in 'textfileoutput-tiny-file.hpl'</note>
+First run 'textfileoutput-tiny-file.hpl', the file needed for this example is generated there</note>
       <xloc>96</xloc>
       <yloc>48</yloc>
-      <width>365</width>
-      <heigth>42</heigth>
+      <width>572</width>
+      <heigth>44</heigth>
       <fontname>Noto Sans</fontname>
-      <fontsize>10</fontsize>
+      <fontsize>14</fontsize>
       <fontbold>N</fontbold>
       <fontitalic>N</fontitalic>
       <fontcolorred>14</fontcolorred>
diff --git a/plugins/transforms/textfile/src/main/samples/transforms/csvinput-huge-file.hpl b/plugins/transforms/textfile/src/main/samples/transforms/csvinput-huge-file.hpl
index 4a14b22..3c6e9b5 100644
--- a/plugins/transforms/textfile/src/main/samples/transforms/csvinput-huge-file.hpl
+++ b/plugins/transforms/textfile/src/main/samples/transforms/csvinput-huge-file.hpl
@@ -41,13 +41,14 @@ limitations under the License.
     <notepad>
       <note>Reads a large csv file and output the results. 
 Check the 'running in parallel' option and increase 'number of copies' for the CSV Input transform.
-This sample uses a file that is generated in 'textfileoutput-huge-file.hpl'</note>
-      <xloc>96</xloc>
+
+First run 'textfileoutput-huge-file.hpl', the file needed for this example is generated there</note>
+      <xloc>80</xloc>
       <yloc>48</yloc>
-      <width>511</width>
-      <heigth>58</heigth>
+      <width>643</width>
+      <heigth>78</heigth>
       <fontname>Noto Sans</fontname>
-      <fontsize>10</fontsize>
+      <fontsize>14</fontsize>
       <fontbold>N</fontbold>
       <fontitalic>N</fontitalic>
       <fontcolorred>14</fontcolorred>
@@ -82,7 +83,7 @@ This sample uses a file that is generated in 'textfileoutput-huge-file.hpl'</not
     <attributes/>
     <GUI>
       <xloc>288</xloc>
-      <yloc>128</yloc>
+      <yloc>160</yloc>
     </GUI>
   </transform>
   <transform>
@@ -158,7 +159,7 @@ This sample uses a file that is generated in 'textfileoutput-huge-file.hpl'</not
     <attributes/>
     <GUI>
       <xloc>112</xloc>
-      <yloc>128</yloc>
+      <yloc>160</yloc>
     </GUI>
   </transform>
   <transform_error_handling>
diff --git a/plugins/transforms/textfile/src/main/samples/transforms/textfileinput-basic.hpl b/plugins/transforms/textfile/src/main/samples/transforms/textfileinput-basic.hpl
index d8f2392..ee802a0 100644
--- a/plugins/transforms/textfile/src/main/samples/transforms/textfileinput-basic.hpl
+++ b/plugins/transforms/textfile/src/main/samples/transforms/textfileinput-basic.hpl
@@ -40,13 +40,13 @@ limitations under the License.
   <notepads>
     <notepad>
       <note>Reads a simple csv file and output the results. 
-This sample uses a file that is generated in 'textfileoutput-tiny-file.hpl'</note>
-      <xloc>96</xloc>
-      <yloc>48</yloc>
-      <width>365</width>
-      <heigth>42</heigth>
+First run 'textfileoutput-tiny-file.hpl', the file needed for this example is generated there</note>
+      <xloc>80</xloc>
+      <yloc>64</yloc>
+      <width>572</width>
+      <heigth>44</heigth>
       <fontname>Noto Sans</fontname>
-      <fontsize>10</fontsize>
+      <fontsize>14</fontsize>
       <fontbold>N</fontbold>
       <fontitalic>N</fontitalic>
       <fontcolorred>14</fontcolorred>