You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "weixiang1862 (via GitHub)" <gi...@apache.org> on 2023/12/01 07:52:41 UTC
[PR] Overlay javaagent by pod annotation. [skywalking-swck]
weixiang1862 opened a new pull request, #105:
URL: https://github.com/apache/skywalking-swck/pull/105
I use workload annotations to inject agent agent name and collector backend_service, I fount javaagent can not get the correct value:
```
[root@15 ~]# kubectl get javaagent -A
NAMESPACE NAME PODSELECTOR SERVICENAME BACKENDSERVICE
gray-demo app-consumer-javaagent app=consumer Your_ApplicationName 127.0.0.1:11800
```
So I add a method `injectConfigByPodAnnotations` after `injectConfigBySwAgent`, then javaagent_controller can overlay config by using pod annotations:
```
[root@15 ~]# kubectl get javaagent -A
NAMESPACE NAME PODSELECTOR SERVICENAME BACKENDSERVICE
gray-demo app-consumer-javaagent app=consumer cluster01-default::consumer 192.168.6.71:11800
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Overlay javaagent by pod annotation. [skywalking-swck]
Posted by "dashanji (via GitHub)" <gi...@apache.org>.
dashanji commented on PR #105:
URL: https://github.com/apache/skywalking-swck/pull/105#issuecomment-1835694245
Hi, @weixiang1862. Thanks for the pr.
It's a bug that the javaagent can not get the correct value. But I suggest changing the code as shown https://github.com/apache/skywalking-swck/pull/100/files#diff-a2f954e637bdd44c3be61ae1617b036e80fd238d321591e3cf704fb292418cdcR101
Thus, you can get all configurations of pod annotations in the java agent rather than the two configurations `backend_service` and `service_name`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Overlay javaagent by pod annotation. [skywalking-swck]
Posted by "weixiang1862 (via GitHub)" <gi...@apache.org>.
weixiang1862 closed pull request #105: Overlay javaagent by pod annotation.
URL: https://github.com/apache/skywalking-swck/pull/105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Overlay javaagent by pod annotation. [skywalking-swck]
Posted by "weixiang1862 (via GitHub)" <gi...@apache.org>.
weixiang1862 commented on PR #105:
URL: https://github.com/apache/skywalking-swck/pull/105#issuecomment-1837034012
> > Thanks, your code implementation is better. I did not notice you hava already fix it, I will close this pr.
>
> Hi, @weixiang1862 please don't worry about this. I mean you can reuse the code implementation here.
>
> BTW, the observability of swagent is not enough, it only supports the `SERVICENAME ` and `BACKENDSERVICE ` rather than all configurations of java agent. Do you have any interest in it?
Yes, I will do some research first and share my ideas here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Overlay javaagent by pod annotation. [skywalking-swck]
Posted by "dashanji (via GitHub)" <gi...@apache.org>.
dashanji commented on PR #105:
URL: https://github.com/apache/skywalking-swck/pull/105#issuecomment-1835978653
> Thanks, your code implementation is better. I did not notice you hava already fix it, I will close this pr.
Hi, @weixiang1862 please don't worry about this. I mean you can reuse the code implementation here.
BTW, the observability of swagent is not enough, it only supports the `SERVICENAME ` and `BACKENDSERVICE ` rather than all configurations of java agent. Do you have any interest in it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Overlay javaagent by pod annotation. [skywalking-swck]
Posted by "weixiang1862 (via GitHub)" <gi...@apache.org>.
weixiang1862 commented on PR #105:
URL: https://github.com/apache/skywalking-swck/pull/105#issuecomment-1835736502
> Hi, @weixiang1862. Thanks for the pr.
>
> It's a bug that the javaagent can not get the correct value. But I suggest changing the code as shown https://github.com/apache/skywalking-swck/pull/100/files#diff-a2f954e637bdd44c3be61ae1617b036e80fd238d321591e3cf704fb292418cdcR101
>
> Thus, you can get all configurations of pod annotations in the java agent rather than the two configurations `backend_service` and `service_name`.
Thanks, your code implementation is better.
I did not notice you hava already fix it, I will close this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org