[GitHub] [celix] PengZheng commented on a diff in pull request #448: Fix several resource leaks and locking issues reported by coverity

[GitBox <gi...@apache.org>]

PengZheng commented on code in PR #448:
URL: https://github.com/apache/celix/pull/448#discussion_r1033069784


##########
bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_handler.c:
##########
@@ -607,6 +607,7 @@ int pubsub_tcpHandler_listen(pubsub_tcpHandler_t *handle, char *url) {
             }
             celixThreadRwlock_unlock(&handle->dbLock);
         } else {
+            free(pUrl);

Review Comment:
   Is fd also leaked? I think fd leakage also happens in the other branch.



##########
bundles/remote_services/rsa_common/src/endpoint_description.c:
##########
@@ -92,7 +92,7 @@ static celix_status_t endpointDescription_verifyLongProperty(celix_properties_t
 }
 
 bool endpointDescription_isInvalid(const endpoint_description_t *description) {

Review Comment:
   This function is used in many places. I suggest that Xu have a look at this to make sure that it will not break some invariants.
   
   What problem does it cause?  Shall we apply for coverity access?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org