[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11163: refactor: Replace usages of Popover from react-bootstrap with Antd

[GitBox <gi...@apache.org>]

kgabryje commented on a change in pull request #11163:
URL: https://github.com/apache/incubator-superset/pull/11163#discussion_r504817357



##########
File path: superset-frontend/stylesheets/antd/index.less
##########
@@ -21,10 +21,6 @@
 @import '~antd/lib/style/mixins/index';
 @import '~antd/lib/style/core/base';
 
-*[class*='ant-'] {

Review comment:
       The global styles don't seem to use the colour variables we have defined below and it appears that the components are styled correctly.
   As for moving on from LESS variables to Emotion, it sounds good, but I'd suggest creating a separate task/issue and refactoring it in a separate PR. This one is far too big already...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org