You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/02/25 15:59:41 UTC

[GitHub] [servicecomb-service-center] ChinX opened a new pull request #636: [SCB-1789] Use etcd option to optimize dependencies

ChinX opened a new pull request #636: [SCB-1789] Use etcd option to optimize dependencies
URL: https://github.com/apache/servicecomb-service-center/pull/636
 
 
   Base on PR #635
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] ChinX closed pull request #636: [SCB-1789] Use etcd option to optimize dependencies

Posted by GitBox <gi...@apache.org>.
ChinX closed pull request #636: [SCB-1789] Use etcd option to optimize dependencies
URL: https://github.com/apache/servicecomb-service-center/pull/636
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] ChinX opened a new pull request #636: [SCB-1789] Use etcd option to optimize dependencies

Posted by GitBox <gi...@apache.org>.
ChinX opened a new pull request #636: [SCB-1789] Use etcd option to optimize dependencies
URL: https://github.com/apache/servicecomb-service-center/pull/636
 
 
   Base on PR #635
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] zenlint merged pull request #636: [SCB-1789] [Syncer] Use etcd option to optimize dependencies

Posted by GitBox <gi...@apache.org>.
zenlint merged pull request #636: [SCB-1789] [Syncer] Use etcd option to optimize dependencies
URL: https://github.com/apache/servicecomb-service-center/pull/636
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] coveralls edited a comment on issue #636: [SCB-1789] [Syncer] Use etcd option to optimize dependencies

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #636: [SCB-1789] [Syncer] Use etcd option to optimize dependencies
URL: https://github.com/apache/servicecomb-service-center/pull/636#issuecomment-591487512
 
 
   
   [![Coverage Status](https://coveralls.io/builds/28977721/badge)](https://coveralls.io/builds/28977721)
   
   Coverage increased (+0.8%) to 60.52% when pulling **2ed74683737d9a75459e7f9c6c0e7a8b534783b2 on ChinX:syncer-etcd** into **ab4ec2eef3ffe6a24a55e833792520cbf05cc322 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] codecov-io edited a comment on issue #636: [SCB-1789] [Syncer] Use etcd option to optimize dependencies

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #636: [SCB-1789] [Syncer] Use etcd option to optimize dependencies
URL: https://github.com/apache/servicecomb-service-center/pull/636#issuecomment-591487577
 
 
   # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/636?src=pr&el=h1) Report
   > Merging [#636](https://codecov.io/gh/apache/servicecomb-service-center/pull/636?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/85dc71bdc30cb3a226170b99c98e8e3df6cc5c78?src=pr&el=desc) will **increase** coverage by `0.99%`.
   > The diff coverage is `86.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/636/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/636?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #636      +/-   ##
   ==========================================
   + Coverage   57.12%   58.12%   +0.99%     
   ==========================================
     Files         207      214       +7     
     Lines       16062    16309     +247     
   ==========================================
   + Hits         9175     9479     +304     
   + Misses       6220     6161      -59     
   - Partials      667      669       +2
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/636?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [syncer/pkg/utils/atomic\_bool.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/636/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy91dGlscy9hdG9taWNfYm9vbC5nbw==) | `100% <100%> (ø)` | |
   | [syncer/task/idle/idle.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/636/diff?src=pr&el=tree#diff-c3luY2VyL3Rhc2svaWRsZS9pZGxlLmdv) | `100% <100%> (ø)` | |
   | [syncer/task/task.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/636/diff?src=pr&el=tree#diff-c3luY2VyL3Rhc2svdGFzay5nbw==) | `100% <100%> (ø)` | |
   | [syncer/task/ticker/ticker.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/636/diff?src=pr&el=tree#diff-c3luY2VyL3Rhc2svdGlja2VyL3RpY2tlci5nbw==) | `100% <100%> (ø)` | |
   | [syncer/serf/agent.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/636/diff?src=pr&el=tree#diff-c3luY2VyL3NlcmYvYWdlbnQuZ28=) | `43.95% <44.44%> (+4.16%)` | :arrow_up: |
   | [syncer/pkg/utils/addr.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/636/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy91dGlscy9hZGRyLmdv) | `56.25% <57.14%> (-7.39%)` | :arrow_down: |
   | [syncer/etcd/etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/636/diff?src=pr&el=tree#diff-c3luY2VyL2V0Y2QvZXRjZC5nbw==) | `75.92% <75.92%> (ø)` | |
   | [syncer/config/verify.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/636/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy92ZXJpZnkuZ28=) | `81.9% <81.9%> (ø)` | |
   | [syncer/etcd/option.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/636/diff?src=pr&el=tree#diff-c3luY2VyL2V0Y2Qvb3B0aW9uLmdv) | `89.36% <89.36%> (ø)` | |
   | [syncer/config/merge.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/636/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy9tZXJnZS5nbw==) | `92.53% <92.53%> (ø)` | |
   | ... and [26 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/636/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/636?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/636?src=pr&el=footer). Last update [85dc71b...0179b14](https://codecov.io/gh/apache/servicecomb-service-center/pull/636?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] codecov-io commented on issue #636: [SCB-1789] Use etcd option to optimize dependencies

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #636: [SCB-1789] Use etcd option to optimize dependencies
URL: https://github.com/apache/servicecomb-service-center/pull/636#issuecomment-591487577
 
 
   # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/636?src=pr&el=h1) Report
   > Merging [#636](https://codecov.io/gh/apache/servicecomb-service-center/pull/636?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/85dc71bdc30cb3a226170b99c98e8e3df6cc5c78?src=pr&el=desc) will **increase** coverage by `1.06%`.
   > The diff coverage is `86.76%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/636/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/636?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #636      +/-   ##
   ==========================================
   + Coverage   57.12%   58.18%   +1.06%     
   ==========================================
     Files         207      214       +7     
     Lines       16062    16310     +248     
   ==========================================
   + Hits         9175     9490     +315     
   + Misses       6220     6153      -67     
     Partials      667      667
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/636?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [syncer/pkg/utils/atomic\_bool.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/636/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy91dGlscy9hdG9taWNfYm9vbC5nbw==) | `100% <100%> (ø)` | |
   | [syncer/task/idle/idle.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/636/diff?src=pr&el=tree#diff-c3luY2VyL3Rhc2svaWRsZS9pZGxlLmdv) | `100% <100%> (ø)` | |
   | [syncer/task/task.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/636/diff?src=pr&el=tree#diff-c3luY2VyL3Rhc2svdGFzay5nbw==) | `100% <100%> (ø)` | |
   | [syncer/task/ticker/ticker.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/636/diff?src=pr&el=tree#diff-c3luY2VyL3Rhc2svdGlja2VyL3RpY2tlci5nbw==) | `100% <100%> (ø)` | |
   | [syncer/serf/agent.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/636/diff?src=pr&el=tree#diff-c3luY2VyL3NlcmYvYWdlbnQuZ28=) | `43.95% <44.44%> (+4.16%)` | :arrow_up: |
   | [syncer/pkg/utils/addr.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/636/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy91dGlscy9hZGRyLmdv) | `56.25% <57.14%> (-7.39%)` | :arrow_down: |
   | [syncer/etcd/etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/636/diff?src=pr&el=tree#diff-c3luY2VyL2V0Y2QvZXRjZC5nbw==) | `75.92% <75.92%> (ø)` | |
   | [syncer/config/verify.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/636/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy92ZXJpZnkuZ28=) | `81.9% <81.9%> (ø)` | |
   | [syncer/etcd/option.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/636/diff?src=pr&el=tree#diff-c3luY2VyL2V0Y2Qvb3B0aW9uLmdv) | `89.36% <89.36%> (ø)` | |
   | [syncer/config/merge.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/636/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy9tZXJnZS5nbw==) | `92.53% <92.53%> (ø)` | |
   | ... and [27 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/636/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/636?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/636?src=pr&el=footer). Last update [85dc71b...48dcb89](https://codecov.io/gh/apache/servicecomb-service-center/pull/636?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] coveralls edited a comment on issue #636: [SCB-1789] [Syncer] Use etcd option to optimize dependencies

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #636: [SCB-1789] [Syncer] Use etcd option to optimize dependencies
URL: https://github.com/apache/servicecomb-service-center/pull/636#issuecomment-591487512
 
 
   
   [![Coverage Status](https://coveralls.io/builds/28979679/badge)](https://coveralls.io/builds/28979679)
   
   Coverage increased (+1.0%) to 60.636% when pulling **0179b1476b73a35646bee6e4270be6084c9fddd7 on ChinX:syncer-etcd** into **ab4ec2eef3ffe6a24a55e833792520cbf05cc322 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] zenlint commented on issue #636: [SCB-1789] [Syncer] Use etcd option to optimize dependencies

Posted by GitBox <gi...@apache.org>.
zenlint commented on issue #636: [SCB-1789] [Syncer] Use etcd option to optimize dependencies
URL: https://github.com/apache/servicecomb-service-center/pull/636#issuecomment-604250504
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] coveralls commented on issue #636: [SCB-1789] Use etcd option to optimize dependencies

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #636: [SCB-1789] Use etcd option to optimize dependencies
URL: https://github.com/apache/servicecomb-service-center/pull/636#issuecomment-591487512
 
 
   
   [![Coverage Status](https://coveralls.io/builds/28975770/badge)](https://coveralls.io/builds/28975770)
   
   Coverage increased (+1.0%) to 60.646% when pulling **48dcb89ef116c56d0cc4e914c680cb7c66082d03 on ChinX:syncer-etcd** into **ab4ec2eef3ffe6a24a55e833792520cbf05cc322 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] coveralls edited a comment on issue #636: [SCB-1789] [Syncer] Use etcd option to optimize dependencies

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #636: [SCB-1789] [Syncer] Use etcd option to optimize dependencies
URL: https://github.com/apache/servicecomb-service-center/pull/636#issuecomment-591487512
 
 
   
   [![Coverage Status](https://coveralls.io/builds/29610239/badge)](https://coveralls.io/builds/29610239)
   
   Coverage increased (+0.2%) to 60.597% when pulling **9e8fec3e9a52e1f9a30e7e5f66d01ffc4ff556fa on ChinX:syncer-etcd** into **ab569eda67981a813942b1b92e7b2be099ba5519 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services