Re: [PR] Optimizing Variant read path with lazy caching [parquet-java]

["steveloughran (via GitHub)" <gi...@apache.org>]

steveloughran commented on code in PR #3481:
URL: https://github.com/apache/parquet-java/pull/3481#discussion_r3095611415


##########
parquet-variant/src/main/java/org/apache/parquet/variant/Variant.java:
##########
@@ -36,6 +36,26 @@ public final class Variant {
    */
   final ByteBuffer metadata;
 
+  /**
+   * Pre-computed metadata dictionary size

Review Comment:
   nit. add a "." at the end as some java versions' javadocs really blow up if you don't.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org