You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "rok (via GitHub)" <gi...@apache.org> on 2023/10/03 13:58:41 UTC
[PR] GH-37988: [Format] Add VariableShapeTensor canonical extension type definition [arrow]
rok opened a new pull request, #37992:
URL: https://github.com/apache/arrow/pull/37992
### Rationale for this change
We want to add a canonical extension type definition for arrays containing tensors with variable shapes.
### What changes are included in this PR?
This amends canonical extensions list in documentation.
### Are these changes tested?
Proposed changes are not tested as they are only for documentation. Proposed type is implemented and tested in #37166.
### Are there any user-facing changes?
Through documentation only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37988: [Format] Add VariableShapeTensor canonical extension type definition [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37992:
URL: https://github.com/apache/arrow/pull/37992#issuecomment-1745038888
:warning: GitHub issue #37988 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37988: [Format] Add VariableShapeTensor canonical extension type definition [arrow]
Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #37992:
URL: https://github.com/apache/arrow/pull/37992#issuecomment-1746536220
Closing in favor of #38008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37988: [Format] Add VariableShapeTensor canonical extension type definition [arrow]
Posted by "rok (via GitHub)" <gi...@apache.org>.
rok closed pull request #37992: GH-37988: [Format] Add VariableShapeTensor canonical extension type definition
URL: https://github.com/apache/arrow/pull/37992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37988: [Format] Add VariableShapeTensor canonical extension type definition [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #37992:
URL: https://github.com/apache/arrow/pull/37992#issuecomment-1746321419
@rok I would maybe suggest doing it the other way around: make a separate PR for the implementation, and keep https://github.com/apache/arrow/pull/37166 for the format specification, because all discussion about the format happened already on that PR (essentially all discussion there was about the spec, and not yet about the implementation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37988: [Format] Add VariableShapeTensor canonical extension type definition [arrow]
Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #37992:
URL: https://github.com/apache/arrow/pull/37992#issuecomment-1746506616
@jorisvandenbossche that's a fair point, I'll do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org